fix(UX): Optimize rate updation on changing price list #28953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepeshgarg007
requested review from
ankush,
marination and
rohitwaghchaure
as code owners
…into price_fetch_optimize
deepeshgarg007
changed the title
|
@Mergifyio backport develop |
🟠 Waiting for conditions to match
|
✅ Backports have been created
|
deepeshgarg007
added a commit
that referenced
this pull request
Dec 26, 2021
fix(UX): Optimize rate updation on changing price list (backport #28953)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider a scenario where you selected more than 100 items in an Invoice and then later realize that the price list selected is incorrect
On changing the price list rate and other related fields are updated and triggers like
calculate_taxes_and_chargesare run for each row which freezes the form for minutes in some cases and the user has to wait for to make other updatesSolution: Do not call any triggers and just cal the required functions manually either at the item or parent level