Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow user to change the parent company #28983

Conversation

anupamvs
Copy link
Contributor

@anupamvs anupamvs commented Dec 21, 2021

Issues-

  • Currently, users are not able to change the parent company of a company.
  • To view the Consolidated Financial Statements, the User would like to make these companies child companies under one Parent company.

Fix-

  • Made Parent company field editable.
  • rebuild tree, if the parent company is changed.
    parent_company

docs- https://docs.erpnext.com/docs/v13/user/manual/en/setting-up/company-setup#210-change-parent-company

@anupamvs anupamvs changed the title feat: allow user to change parent company feat: allow user to change the parent company Dec 21, 2021
@rohitwaghchaure rohitwaghchaure added the needs-tests This PR needs automated unit-tests. label Dec 23, 2021
@codecov
Copy link

codecov bot commented Dec 30, 2021

Codecov Report

Merging #28983 (f3c5cb9) into develop (56b9ad8) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop   #28983      +/-   ##
===========================================
- Coverage    55.68%   55.60%   -0.09%     
===========================================
  Files         1129     1129              
  Lines        67471    67479       +8     
===========================================
- Hits         37574    37524      -50     
- Misses       29897    29955      +58     
Impacted Files Coverage Δ
erpnext/setup/doctype/company/company.py 72.66% <100.00%> (+0.72%) ⬆️
...eport/item_variant_details/item_variant_details.py 31.32% <0.00%> (-53.02%) ⬇️
...tch_item_expiry_status/batch_item_expiry_status.py 69.23% <0.00%> (-25.00%) ⬇️
erpnext/education/doctype/student/student.py 73.68% <0.00%> (-3.16%) ⬇️
erpnext/stock/report/stock_ledger/stock_ledger.py 74.79% <0.00%> (-2.44%) ⬇️
erpnext/stock/report/stock_ageing/stock_ageing.py 91.32% <0.00%> (-2.32%) ⬇️
...ion/doctype/course_enrollment/course_enrollment.py 44.00% <0.00%> (-2.00%) ⬇️
...eorder_level/itemwise_recommended_reorder_level.py 92.45% <0.00%> (-1.89%) ⬇️
.../hr/doctype/upload_attendance/upload_attendance.py 44.69% <0.00%> (-1.52%) ⬇️
erpnext/stock/get_item_details.py 79.29% <0.00%> (-0.16%) ⬇️
... and 11 more

@anupamvs anupamvs removed the needs-tests This PR needs automated unit-tests. label Dec 30, 2021
@anupamvs
Copy link
Contributor Author

@Mergifyio backport version-13-hotfix

@mergify
Copy link
Contributor

mergify bot commented Dec 30, 2021

backport version-13-hotfix

🟠 Waiting for conditions to match

  • merged [:pushpin: backport requirement]

@nextchamp-saqib nextchamp-saqib merged commit 08dcbd6 into frappe:develop Jan 4, 2022
@mergify
Copy link
Contributor

mergify bot commented Jan 4, 2022

backport version-13-hotfix

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants