Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect serial no valuation #28987

Merged
merged 3 commits into from
Jan 17, 2022
Merged

Conversation

ankush
Copy link
Member

@ankush ankush commented Dec 21, 2021

Steps to reproduce:

  1. have multiple serial nos with different rates
  2. Create a delivery for 1 serial no; do not submit.
  3. Update serial number to some other number with different purchase/manufacture rates.
  4. Submit and check stock value difference. It should be same as incoming rate but it would be from previous serial no instead.

caused by & potentially affected use cases: #25306 & #27036

To Test:

  • The case above
  • Delivery return of a serial no (single) and multiple serial nos

@stale stale bot added the inactive label Jan 6, 2022
@frappe frappe deleted a comment from stale bot Jan 7, 2022
@stale stale bot removed the inactive label Jan 7, 2022
@ankush ankush added the hotfix label Jan 7, 2022
@codecov
Copy link

codecov bot commented Jan 7, 2022

Codecov Report

Merging #28987 (5d27a76) into develop (3438e1f) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop   #28987   +/-   ##
========================================
  Coverage    57.93%   57.93%           
========================================
  Files         1110     1110           
  Lines        68087    68087           
========================================
  Hits         39449    39449           
  Misses       28638    28638           
Impacted Files Coverage Δ
erpnext/controllers/selling_controller.py 79.06% <100.00%> (ø)
erpnext/stock/stock_ledger.py 85.76% <100.00%> (+0.36%) ⬆️
...eport/item_variant_details/item_variant_details.py 31.32% <0.00%> (-56.63%) ⬇️
...wise_balance_history/batch_wise_balance_history.py 68.96% <0.00%> (-24.14%) ⬇️
...xt/stock/report/stock_analytics/stock_analytics.py 91.08% <0.00%> (-1.99%) ⬇️
...eorder_level/itemwise_recommended_reorder_level.py 92.45% <0.00%> (-1.89%) ⬇️
erpnext/stock/reorder_item.py 76.06% <0.00%> (-1.71%) ⬇️
...r/doctype/leave_ledger_entry/leave_ledger_entry.py 90.16% <0.00%> (-1.64%) ⬇️
erpnext/stock/report/stock_ledger/stock_ledger.py 76.42% <0.00%> (-1.63%) ⬇️
.../report/stock_projected_qty/stock_projected_qty.py 88.15% <0.00%> (-1.32%) ⬇️
... and 26 more

@ankush ankush changed the title fix: incorrect incoming rate computation for sr no fix: multiple stock ledger issues Jan 7, 2022
@ankush ankush added needs-tests This PR needs automated unit-tests. backport version-13-hotfix and removed needs-tests This PR needs automated unit-tests. labels Jan 7, 2022
@github-actions github-actions bot added needs-tests This PR needs automated unit-tests. selling stock labels Jan 9, 2022
@ankush ankush removed the needs-tests This PR needs automated unit-tests. label Jan 9, 2022
@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Jan 9, 2022
@ankush ankush removed the needs-tests This PR needs automated unit-tests. label Jan 9, 2022
@ankush ankush force-pushed the fix/srvaluation branch 2 times, most recently from b3f7550 to 5d9ebbb Compare January 9, 2022 14:50
@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Jan 9, 2022
@ankush ankush removed the needs-tests This PR needs automated unit-tests. label Jan 9, 2022
@ankush ankush force-pushed the fix/srvaluation branch 7 times, most recently from c94c963 to 39beb90 Compare January 13, 2022 14:34
@ankush ankush changed the title fix: multiple stock ledger issues fix: incorrect serial no valuation Jan 16, 2022
@ankush ankush marked this pull request as ready for review January 16, 2022 12:37
@ankush ankush added this to the v13.19 milestone Jan 16, 2022
@marination marination merged commit dbda10e into frappe:develop Jan 17, 2022
ankush added a commit that referenced this pull request Jan 17, 2022
…-28987

fix: incorrect serial no valuation (backport #28987)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants