-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: incorrect serial no valuation #28987
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankush
force-pushed
the
fix/srvaluation
branch
from
December 22, 2021 08:10
41ec884
to
9bcd559
Compare
ankush
force-pushed
the
fix/srvaluation
branch
from
January 7, 2022 05:40
9bcd559
to
e12e508
Compare
Codecov Report
@@ Coverage Diff @@
## develop #28987 +/- ##
========================================
Coverage 57.93% 57.93%
========================================
Files 1110 1110
Lines 68087 68087
========================================
Hits 39449 39449
Misses 28638 28638
|
ankush
changed the title
fix: incorrect incoming rate computation for sr no
fix: multiple stock ledger issues
Jan 7, 2022
ankush
added
needs-tests
This PR needs automated unit-tests.
backport version-13-hotfix
and removed
needs-tests
This PR needs automated unit-tests.
labels
Jan 7, 2022
ankush
force-pushed
the
fix/srvaluation
branch
from
January 9, 2022 14:42
e12e508
to
5d9ebbb
Compare
github-actions
bot
added
needs-tests
This PR needs automated unit-tests.
selling
stock
labels
Jan 9, 2022
ankush
force-pushed
the
fix/srvaluation
branch
from
January 9, 2022 14:46
2658404
to
c8d1d3a
Compare
ankush
force-pushed
the
fix/srvaluation
branch
2 times, most recently
from
January 9, 2022 14:50
b3f7550
to
5d9ebbb
Compare
ankush
force-pushed
the
fix/srvaluation
branch
7 times, most recently
from
January 13, 2022 14:34
c94c963
to
39beb90
Compare
ankush
changed the title
fix: multiple stock ledger issues
fix: incorrect serial no valuation
Jan 16, 2022
ankush
force-pushed
the
fix/srvaluation
branch
from
January 16, 2022 07:31
39beb90
to
fcc885b
Compare
ankush
requested review from
deepeshgarg007,
marination,
nextchamp-saqib and
rohitwaghchaure
as code owners
January 16, 2022 12:37
marination
approved these changes
Jan 17, 2022
ankush
added a commit
that referenced
this pull request
Jan 17, 2022
…-28987 fix: incorrect serial no valuation (backport #28987)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce:
caused by & potentially affected use cases: #25306 & #27036
To Test: