style: better labels for SLE fields #28988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankush
commented
Dec 21, 2021
erpnext/stock/doctype/stock_ledger_entry/stock_ledger_entry.json
Outdated
Show resolved
Hide resolved
[skip ci] Co-Authored-by: marination <maricadsouza221197@gmail.com>
ankush
added
the
squash
conncampbell
pushed a commit
to conncampbell/erpnext
that referenced
this pull request
Jan 9, 2022
* style: better labels for SLE fields * style: rename stock queue field [skip ci] Co-Authored-by: marination <maricadsouza221197@gmail.com>
conncampbell
pushed a commit
to conncampbell/erpnext
that referenced
this pull request
Jan 9, 2022
* style: better labels for SLE fields * style: rename stock queue field [skip ci] Co-Authored-by: marination <maricadsouza221197@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These things are very confusing to new devs, specifically, the "actual" part is quite pointless. This just renames few labels, not touching the field names for now. (too much patching and breaking change in code)
Actual Qty -> Qty change
Actual Qty After Transaction -> Qty After Transaction
Stock Value -> Balance Stock Value
Stock Value Difference -> Change in Stock Value
Stock Queue (FIFO) -> FIFO Queue (qty, rate)