Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cannot create debit note with zero qty #28994

Merged
merged 3 commits into from
Jan 7, 2022

Conversation

nextchamp-saqib
Copy link
Member

It is possible to create a Credit Note to adjust the amount without discounting the quantity. The same is not possible for Debit Notes. This PR aims to fix that.

@nextchamp-saqib nextchamp-saqib changed the title fix(sales-invoice): cannot create debit note with zero qty fix: cannot create debit note with zero qty Dec 22, 2021
@nextchamp-saqib nextchamp-saqib added this to the v13.19 milestone Dec 22, 2021
@codecov
Copy link

codecov bot commented Dec 29, 2021

Codecov Report

Merging #28994 (79ccf80) into develop (56b9ad8) will increase coverage by 0.01%.
The diff coverage is 66.66%.

@@             Coverage Diff             @@
##           develop   #28994      +/-   ##
===========================================
+ Coverage    55.68%   55.70%   +0.01%     
===========================================
  Files         1129     1129              
  Lines        67471    67473       +2     
===========================================
+ Hits         37574    37583       +9     
+ Misses       29897    29890       -7     
Impacted Files Coverage Δ
erpnext/controllers/taxes_and_totals.py 97.46% <50.00%> (-0.19%) ⬇️
erpnext/controllers/accounts_controller.py 83.93% <100.00%> (ø)
erpnext/utilities/product.py 14.70% <0.00%> (-35.30%) ⬇️
erpnext/shopping_cart/product_info.py 30.30% <0.00%> (-21.22%) ⬇️
...ctype/woocommerce_settings/woocommerce_settings.py 80.00% <0.00%> (-4.00%) ⬇️
.../report/bom_operations_time/bom_operations_time.py 93.33% <0.00%> (-3.34%) ⬇️
...e/shopping_cart_settings/shopping_cart_settings.py 65.38% <0.00%> (-1.93%) ⬇️
...r/doctype/leave_ledger_entry/leave_ledger_entry.py 90.16% <0.00%> (-1.64%) ⬇️
.../hr/doctype/upload_attendance/upload_attendance.py 44.69% <0.00%> (-1.52%) ⬇️
erpnext/shopping_cart/product_query.py 61.19% <0.00%> (-1.50%) ⬇️
... and 20 more

@deepeshgarg007 deepeshgarg007 self-assigned this Jan 7, 2022
@deepeshgarg007 deepeshgarg007 marked this pull request as ready for review January 7, 2022 13:03
@deepeshgarg007 deepeshgarg007 merged commit b83608b into frappe:develop Jan 7, 2022
deepeshgarg007 added a commit that referenced this pull request Jan 7, 2022
…-28994

fix: cannot create debit note with zero qty (backport #28994)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants