Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: contact duplication on converting lead to customer #29001

Merged
merged 3 commits into from
Dec 24, 2021
Merged

fix: contact duplication on converting lead to customer #29001

merged 3 commits into from
Dec 24, 2021

Conversation

anupamvs
Copy link
Contributor

Issue - #28910

@anupamvs anupamvs linked an issue Dec 22, 2021 that may be closed by this pull request
Two contacts gets created for one Lead #28910
Closed
1 task
@anupamvs
Copy link
Contributor Author

@Mergifyio backport version-13-hotfix

@mergify
Copy link
Contributor

mergify bot commented Dec 22, 2021

backport version-13-hotfix

🟠 Waiting for conditions to match

  • merged [:pushpin: backport requirement]

@anupamvs
Copy link
Contributor Author

@Mergifyio backport version-13-pre-release

@mergify
Copy link
Contributor

mergify bot commented Dec 22, 2021

backport version-13-pre-release

🟠 Waiting for conditions to match

  • merged [:pushpin: backport requirement]

@nextchamp-saqib nextchamp-saqib added the needs-tests This PR needs automated unit-tests. label Dec 23, 2021
@anupamvs anupamvs removed the needs-tests This PR needs automated unit-tests. label Dec 24, 2021
@codecov
Copy link

codecov bot commented Dec 24, 2021

Codecov Report

Merging #29001 (3f3e391) into develop (6eeea0a) will increase coverage by 9.38%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop   #29001      +/-   ##
===========================================
+ Coverage    46.16%   55.54%   +9.38%     
===========================================
  Files         1128     1128              
  Lines        67295    67295              
===========================================
+ Hits         31066    37379    +6313     
+ Misses       36229    29916    -6313
Impacted Files Coverage Δ
erpnext/selling/doctype/customer/customer.py 64.70% <100.00%> (+21.47%) ⬆️
erpnext/utilities/product.py 14.70% <0.00%> (-35.30%) ⬇️
erpnext/shopping_cart/product_info.py 30.30% <0.00%> (-21.22%) ⬇️
...e/shopping_cart_settings/shopping_cart_settings.py 65.38% <0.00%> (-1.93%) ⬇️
erpnext/shopping_cart/product_query.py 61.19% <0.00%> (-1.50%) ⬇️
erpnext/portal/product_configurator/utils.py 33.06% <0.00%> (-0.41%) ⬇️
erpnext/accounts/utils.py 58.68% <0.00%> (-0.19%) ⬇️
erpnext/portal/utils.py 28.98% <0.00%> (ø)
erpnext/controllers/taxes_and_totals.py 97.65% <0.00%> (+0.39%) ⬆️
erpnext/accounts/doctype/account/account.py 71.76% <0.00%> (+0.39%) ⬆️
... and 204 more

@anupamvs anupamvs merged commit cfb6b26 into frappe:develop Dec 24, 2021
mergify bot pushed a commit that referenced this pull request Dec 24, 2021
@anupamvs
fix: contact duplication on converting lead to customer (#29001)
cd0b0b8 
* fix: contact duplication on converting lead to customer

* fix: added test case

(cherry picked from commit cfb6b26)

# Conflicts:
#	erpnext/selling/doctype/customer/customer.py
@mergify mergify bot mentioned this pull request Dec 24, 2021
Closed
@mergify
Copy link
Contributor

mergify bot commented Dec 24, 2021

backport version-13-pre-release

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Dec 24, 2021
@anupamvs
fix: contact duplication on converting lead to customer (#29001)
0910fa8 
* fix: contact duplication on converting lead to customer

* fix: added test case

(cherry picked from commit cfb6b26)

# Conflicts:
#	erpnext/selling/doctype/customer/customer.py
@mergify mergify bot mentioned this pull request Dec 24, 2021
Closed
@mergify
Copy link
Contributor

mergify bot commented Dec 24, 2021

backport version-13-hotfix

✅ Backports have been created

conncampbell pushed a commit to conncampbell/erpnext that referenced this pull request Jan 9, 2022
@anupamvs
fix: contact duplication on converting lead to customer (frappe#29001)
615c0d6 
* fix: contact duplication on converting lead to customer

* fix: added test case
conncampbell pushed a commit to conncampbell/erpnext that referenced this pull request Jan 9, 2022
@anupamvs
fix: contact duplication on converting lead to customer (frappe#29001)
13b791d 
* fix: contact duplication on converting lead to customer

* fix: added test case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepeshgarg007 deepeshgarg007 Awaiting requested review from deepeshgarg007 deepeshgarg007 is a code owner

@pateljannat pateljannat Awaiting requested review from pateljannat

@ruchamahabal ruchamahabal Awaiting requested review from ruchamahabal

@nextchamp-saqib nextchamp-saqib Awaiting requested review from nextchamp-saqib

Assignees

@nextchamp-saqib nextchamp-saqib

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Two contacts gets created for one Lead
2 participants
@anupamvs @nextchamp-saqib