-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: disable renaming on serial nos #29014
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New serial nos can simply be deleted and recreated if mistake is made. modifying delivered/manufactured sr no should not be allowed.
ankush
changed the title
fix: disable renaming on serial nos
fix!: disable renaming on serial nos
Dec 23, 2021
ankush
added
the
squash
Meant to tell reviewers that this PR should be squashed into a single commit while merging.
label
Dec 23, 2021
Codecov Report
@@ Coverage Diff @@
## develop #29014 +/- ##
========================================
Coverage 55.61% 55.61%
========================================
Files 1128 1128
Lines 67345 67337 -8
========================================
- Hits 37451 37450 -1
+ Misses 29894 29887 -7
|
marination
approved these changes
Dec 28, 2021
mergify bot
pushed a commit
that referenced
this pull request
Dec 28, 2021
fix!: disable renaming on serial nos (cherry picked from commit 087ebca)
@Mergifyio backport version-13-hotfix |
✅ Backports have been created
|
conncampbell
pushed a commit
to conncampbell/erpnext
that referenced
this pull request
Jan 9, 2022
fix!: disable renaming on serial nos
conncampbell
pushed a commit
to conncampbell/erpnext
that referenced
this pull request
Jan 9, 2022
fix!: disable renaming on serial nos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport version-13-hotfix
squash
Meant to tell reviewers that this PR should be squashed into a single commit while merging.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New serial nos can simply be deleted and recreated if a mistake is made.
modifying delivered/manufactured/bought sr no should not be allowed without amending doc.