Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: disable renaming on serial nos #29014

Merged
merged 3 commits into from
Dec 28, 2021
Merged

Conversation

ankush
Copy link
Member

@ankush ankush commented Dec 23, 2021

New serial nos can simply be deleted and recreated if a mistake is made.

modifying delivered/manufactured/bought sr no should not be allowed without amending doc.

Edit: For future reference, a lot of old data that was renamed could happen to not be appropriately renamed in the SLE since its a text field. We want to avoid hacky stuff to incorporate all this - @marination

New serial nos can simply be deleted and recreated if mistake is made.

modifying delivered/manufactured sr no should not be allowed.
@ankush ankush changed the title fix: disable renaming on serial nos fix!: disable renaming on serial nos Dec 23, 2021
@ankush ankush added the squash Meant to tell reviewers that this PR should be squashed into a single commit while merging. label Dec 23, 2021
@marination marination self-assigned this Dec 28, 2021
@codecov
Copy link

codecov bot commented Dec 28, 2021

Codecov Report

Merging #29014 (8857027) into develop (27b157d) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop   #29014   +/-   ##
========================================
  Coverage    55.61%   55.61%           
========================================
  Files         1128     1128           
  Lines        67345    67337    -8     
========================================
- Hits         37451    37450    -1     
+ Misses       29894    29887    -7     
Impacted Files Coverage Δ
erpnext/stock/doctype/serial_no/serial_no.py 79.89% <ø> (+1.13%) ⬆️
erpnext/utilities/product.py 14.70% <0.00%> (-35.30%) ⬇️
erpnext/shopping_cart/product_info.py 30.30% <0.00%> (-21.22%) ⬇️
.../manufacturing/report/bom_explorer/bom_explorer.py 94.44% <0.00%> (-5.56%) ⬇️
...ctype/woocommerce_settings/woocommerce_settings.py 80.00% <0.00%> (-4.00%) ⬇️
erpnext/education/doctype/student/student.py 73.68% <0.00%> (-3.16%) ⬇️
...ion/doctype/course_enrollment/course_enrollment.py 44.00% <0.00%> (-2.00%) ⬇️
...e/shopping_cart_settings/shopping_cart_settings.py 65.38% <0.00%> (-1.93%) ⬇️
erpnext/shopping_cart/product_query.py 61.19% <0.00%> (-1.50%) ⬇️
erpnext/portal/utils.py 28.98% <0.00%> (-1.45%) ⬇️
... and 19 more

@marination marination merged commit 087ebca into frappe:develop Dec 28, 2021
mergify bot pushed a commit that referenced this pull request Dec 28, 2021
fix!: disable renaming on serial nos

(cherry picked from commit 087ebca)
@frappe frappe deleted a comment from mergify bot Dec 28, 2021
@marination
Copy link
Collaborator

@Mergifyio backport version-13-hotfix

@mergify
Copy link
Contributor

mergify bot commented Dec 28, 2021

backport version-13-hotfix

✅ Backports have been created

conncampbell pushed a commit to conncampbell/erpnext that referenced this pull request Jan 9, 2022
fix!: disable renaming on serial nos
conncampbell pushed a commit to conncampbell/erpnext that referenced this pull request Jan 9, 2022
fix!: disable renaming on serial nos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport version-13-hotfix squash Meant to tell reviewers that this PR should be squashed into a single commit while merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants