Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: Removed agriculture module from ERPNext #29022

Merged
merged 1 commit into from
Jan 4, 2022

Conversation

ChillarAnand
Copy link
Contributor

@ChillarAnand ChillarAnand commented Dec 24, 2021

We are moving agriculture in to a seperate app. New app is available at https://github.com/frappe/agriculture.

Please raise new issues/PRs related to agriculture at the new repo.

@ChillarAnand
Copy link
Contributor Author

ChillarAnand commented Dec 27, 2021

A test related to employee holiday list seems to be failing for all the PRs. Looking into it.

@ChillarAnand ChillarAnand requested review from ruchamahabal, ankush and nabinhait and removed request for nabinhait December 27, 2021 05:38
@ChillarAnand
Copy link
Contributor Author

Fixed it in #29040

@codecov
Copy link

codecov bot commented Dec 28, 2021

Codecov Report

Merging #29022 (f2dc2a5) into develop (7e77735) will increase coverage by 8.35%.
The diff coverage is n/a.

❗ Current head f2dc2a5 differs from pull request most recent head b5afef5. Consider uploading reports for the commit b5afef5 to get more accurate results

@@             Coverage Diff             @@
##           develop   #29022      +/-   ##
===========================================
+ Coverage    47.23%   55.59%   +8.35%     
===========================================
  Files         1131     1105      -26     
  Lines        67586    67136     -450     
===========================================
+ Hits         31925    37322    +5397     
+ Misses       35661    29814    -5847     
Impacted Files Coverage Δ
erpnext/hooks.py 0.00% <ø> (ø)
.../setup/setup_wizard/operations/install_fixtures.py 92.99% <ø> (+5.09%) ⬆️
erpnext/crm/utils.py 31.25% <0.00%> (-35.42%) ⬇️
...wise_balance_history/batch_wise_balance_history.py 68.96% <0.00%> (-24.14%) ⬇️
...ctype/woocommerce_settings/woocommerce_settings.py 80.00% <0.00%> (-4.00%) ⬇️
...ype/loan_interest_accrual/loan_interest_accrual.py 87.27% <0.00%> (-3.72%) ⬇️
...eport/item_variant_details/item_variant_details.py 84.33% <0.00%> (-3.62%) ⬇️
erpnext/crm/doctype/lead/lead.py 65.17% <0.00%> (-2.99%) ⬇️
erpnext/selling/doctype/quotation/quotation.py 47.15% <0.00%> (-2.58%) ⬇️
...value/warehouse_wise_item_balance_age_and_value.py 92.40% <0.00%> (-2.54%) ⬇️
... and 245 more

@ankush ankush added the needs-patch A patch to fix existing data is required label Jan 2, 2022
@ChillarAnand ChillarAnand force-pushed the remove-agriculture branch 3 times, most recently from f05afeb to b4b2354 Compare January 3, 2022 11:03
@ChillarAnand ChillarAnand force-pushed the remove-agriculture branch 2 times, most recently from 0d08f77 to 5eec743 Compare January 3, 2022 11:08
@ChillarAnand ChillarAnand removed the needs-patch A patch to fix existing data is required label Jan 3, 2022
@ankush ankush merged commit 0900c3d into frappe:develop Jan 4, 2022
@ankush
Copy link
Member

ankush commented Jan 4, 2022

@ChillarAnand please port warning patch to v13.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants