Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid "string" in None condition #29033

Merged
merged 1 commit into from
Dec 26, 2021
Merged

fix: avoid "string" in None condition #29033

merged 1 commit into from
Dec 26, 2021

Conversation

barredterra
Copy link
Collaborator

Close #29032

@barredterra
Copy link
Collaborator Author

@Mergifyio backport version-13-hotfix version-12-hotfix

@mergify
Copy link
Contributor

mergify bot commented Dec 26, 2021

backport version-13-hotfix version-12-hotfix

🟠 Waiting for conditions to match

  • merged [:pushpin: backport requirement]

@codecov
Copy link

codecov bot commented Dec 26, 2021

Codecov Report

Merging #29033 (52397c9) into develop (cfb6b26) will decrease coverage by 5.05%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #29033      +/-   ##
===========================================
- Coverage    55.57%   50.51%   -5.06%     
===========================================
  Files         1128     1128              
  Lines        67295    67295              
===========================================
- Hits         37401    33996    -3405     
- Misses       29894    33299    +3405     
Impacted Files Coverage Δ
erpnext/regional/france/utils.py 0.00% <0.00%> (-100.00%) ⬇️
erpnext/hr/doctype/driver/driver.py 0.00% <0.00%> (-100.00%) ⬇️
erpnext/accounts/doctype/pos_field/pos_field.py 0.00% <0.00%> (-100.00%) ⬇️
erpnext/support/doctype/issue_type/issue_type.py 0.00% <0.00%> (-100.00%) ⬇️
...rpnext/hr/doctype/grievance_type/grievance_type.py 0.00% <0.00%> (-100.00%) ⬇️
...ext/stock/doctype/pick_list_item/pick_list_item.py 0.00% <0.00%> (-100.00%) ⬇️
.../accounts/doctype/budget_account/budget_account.py 0.00% <0.00%> (-100.00%) ⬇️
...ock/doctype/delivery_settings/delivery_settings.py 0.00% <0.00%> (-100.00%) ⬇️
...iving_license_category/driving_license_category.py 0.00% <0.00%> (-100.00%) ⬇️
...ions/doctype/mpesa_settings/mpesa_custom_fields.py 0.00% <0.00%> (-100.00%) ⬇️
... and 127 more

@mergify
Copy link
Contributor

mergify bot commented Dec 26, 2021

backport version-13-hotfix version-12-hotfix

✅ Backports have been created

marination added a commit that referenced this pull request Dec 28, 2021
…-29033

fix: avoid `"string" in None` condition (backport #29033)
@surajshetty3416 surajshetty3416 deleted the fix-iss-29032 branch January 14, 2022 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: argument of type 'NoneType' is not iterable
2 participants