Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Deferred revenue booking for multi currency invoices via JV #29115

Merged

Conversation

deepeshgarg007
Copy link
Member

@deepeshgarg007 deepeshgarg007 commented Jan 3, 2022

Deferred Revenue for multi-currency Invoices was not booked for the correct amount if booked via JV. Is was still considering the amount in party currency rather than the base amount

@codecov
Copy link

codecov bot commented Jan 3, 2022

Codecov Report

Merging #29115 (fd922f1) into develop (25c875e) will increase coverage by 2.22%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop   #29115      +/-   ##
===========================================
+ Coverage    55.75%   57.98%   +2.22%     
===========================================
  Files         1107     1110       +3     
  Lines        67383    68080     +697     
===========================================
+ Hits         37570    39476    +1906     
+ Misses       29813    28604    -1209     
Impacted Files Coverage Δ
erpnext/controllers/accounts_controller.py 84.49% <ø> (+0.14%) ⬆️
erpnext/accounts/deferred_revenue.py 76.19% <100.00%> (+0.31%) ⬆️
...xt/accounts/doctype/journal_entry/journal_entry.py 68.77% <100.00%> (+0.64%) ⬆️
...payroll/doctype/income_tax_slab/income_tax_slab.py 83.33% <0.00%> (-16.67%) ⬇️
...ucation/doctype/course_schedule/course_schedule.py 83.33% <0.00%> (-13.22%) ⬇️
erpnext/tests/utils.py 93.15% <0.00%> (-3.87%) ⬇️
...e/asset_value_adjustment/asset_value_adjustment.py 86.04% <0.00%> (-3.49%) ⬇️
erpnext/portal/utils.py 28.98% <0.00%> (-1.45%) ⬇️
...evenue_and_expense/deferred_revenue_and_expense.py 61.30% <0.00%> (-0.31%) ⬇️
...next/accounts/doctype/subscription/subscription.py 82.14% <0.00%> (-0.26%) ⬇️
... and 250 more

@deepeshgarg007 deepeshgarg007 added the Skip Manual Testing The changes in this PR does not require manual testing label Jan 7, 2022
@deepeshgarg007
Copy link
Member Author

@Mergifyio backport version-13-hotfix

@deepeshgarg007 deepeshgarg007 merged commit 14e0d00 into frappe:develop Jan 15, 2022
@mergify
Copy link
Contributor

mergify bot commented Jan 15, 2022

backport version-13-hotfix

✅ Backports have been created

deepeshgarg007 added a commit that referenced this pull request Jan 15, 2022
…-29115

fix: Deferred revenue booking for multi currency invoices via JV (backport #29115)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Manual Testing The changes in this PR does not require manual testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant