-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Deferred revenue booking for multi currency invoices via JV #29115
Merged
deepeshgarg007
merged 10 commits into
frappe:develop
from
deepeshgarg007:deferred_revenue_multi_currency_jv
Jan 15, 2022
Merged
fix: Deferred revenue booking for multi currency invoices via JV #29115
deepeshgarg007
merged 10 commits into
frappe:develop
from
deepeshgarg007:deferred_revenue_multi_currency_jv
Jan 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #29115 +/- ##
===========================================
+ Coverage 55.75% 57.98% +2.22%
===========================================
Files 1107 1110 +3
Lines 67383 68080 +697
===========================================
+ Hits 37570 39476 +1906
+ Misses 29813 28604 -1209
|
…rred_revenue_multi_currency_jv
…rred_revenue_multi_currency_jv
deepeshgarg007
requested review from
marination and
rohitwaghchaure
as code owners
January 7, 2022 14:23
deepeshgarg007
added
the
Skip Manual Testing
The changes in this PR does not require manual testing
label
Jan 7, 2022
@Mergifyio backport version-13-hotfix |
✅ Backports have been created
|
deepeshgarg007
added a commit
that referenced
this pull request
Jan 15, 2022
…-29115 fix: Deferred revenue booking for multi currency invoices via JV (backport #29115)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deferred Revenue for multi-currency Invoices was not booked for the correct amount if booked via JV. Is was still considering the amount in party currency rather than the base amount