Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(patch): serial no whitespace trimming #29131

Merged
merged 2 commits into from
Jan 10, 2022

Conversation

ankush
Copy link
Member

@ankush ankush commented Jan 4, 2022

old data can contain trailing/leading whitespace which doesn't work well with code to find last SLE for serial no.

@ankush ankush added Skip Manual Testing The changes in this PR does not require manual testing backport version-13-hotfix labels Jan 4, 2022
@ankush
Copy link
Member Author

ankush commented Jan 4, 2022

unrelated failing test, fixed by e73c51b

@codecov
Copy link

codecov bot commented Jan 7, 2022

Codecov Report

Merging #29131 (7f244bb) into develop (3112343) will increase coverage by 8.25%.
The diff coverage is n/a.

❗ Current head 7f244bb differs from pull request most recent head cbaa8fd. Consider uploading reports for the commit cbaa8fd to get more accurate results

@@             Coverage Diff             @@
##           develop   #29131      +/-   ##
===========================================
+ Coverage    47.55%   55.80%   +8.25%     
===========================================
  Files         1107     1107              
  Lines        67383    67370      -13     
===========================================
+ Hits         32045    37598    +5553     
+ Misses       35338    29772    -5566     
Impacted Files Coverage Δ
erpnext/setup/utils.py 83.14% <0.00%> (-4.50%) ⬇️
erpnext/crm/doctype/prospect/prospect.py 55.22% <0.00%> (-1.50%) ⬇️
erpnext/portal/utils.py 28.98% <0.00%> (-1.45%) ⬇️
...ype/account/chart_of_accounts/chart_of_accounts.py 77.24% <0.00%> (-0.69%) ⬇️
...next/accounts/doctype/subscription/subscription.py 81.84% <0.00%> (-0.56%) ⬇️
..._receivable_summary/accounts_receivable_summary.py 0.00% <0.00%> (ø)
erpnext/selling/doctype/customer/customer.py 64.70% <0.00%> (+0.29%) ⬆️
...ext/manufacturing/doctype/work_order/work_order.py 72.16% <0.00%> (+0.31%) ⬆️
erpnext/accounts/doctype/account/account.py 71.76% <0.00%> (+0.39%) ⬆️
erpnext/portal/product_configurator/utils.py 33.46% <0.00%> (+0.40%) ⬆️
... and 189 more

old data can contain trailing/leading whitespace which doesn't work well
with code to find last SLE for serial no.
@ankush ankush added this to the v13.19 milestone Jan 10, 2022
@marination
Copy link
Collaborator

Only exchangerate tests are failing as service is down
Linter can be ignored here
LGTM

@marination marination merged commit 9d36e30 into frappe:develop Jan 10, 2022
@marination
Copy link
Collaborator

@Mergifyio backport version-13-hotfix

@mergify
Copy link
Contributor

mergify bot commented Jan 10, 2022

backport version-13-hotfix

✅ Backports have been created

ankush added a commit that referenced this pull request Jan 10, 2022
…-29131

fix(patch): serial no whitespace trimming (backport #29131)
@ankush ankush removed the Skip Manual Testing The changes in this PR does not require manual testing label Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants