Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: Removed hospitality domain from ERPNext #29167

Merged
merged 2 commits into from
Jan 20, 2022

Conversation

ChillarAnand
Copy link
Contributor

@ChillarAnand ChillarAnand commented Jan 6, 2022

We are moving Hospitality in to a separate app. New app is available at https://github.com/frappe/hospitality.

Please raise new issues/PRs related to hospitality at the new repo.

@codecov
Copy link

codecov bot commented Jan 6, 2022

Codecov Report

Merging #29167 (7e058c7) into develop (5ae44f3) will decrease coverage by 0.29%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #29167      +/-   ##
===========================================
- Coverage    58.06%   57.77%   -0.30%     
===========================================
  Files         1110     1091      -19     
  Lines        68067    67842     -225     
===========================================
- Hits         39523    39195     -328     
- Misses       28544    28647     +103     
Impacted Files Coverage Δ
erpnext/hooks.py 0.00% <ø> (ø)
...work_order_stock_report/work_order_stock_report.py 50.00% <0.00%> (-50.00%) ⬇️
...unts/report/purchase_register/purchase_register.py 32.19% <0.00%> (-41.10%) ⬇️
...ext/accounts/report/balance_sheet/balance_sheet.py 36.36% <0.00%> (-21.82%) ⬇️
...e_purchase_register/item_wise_purchase_register.py 58.00% <0.00%> (-17.00%) ⬇️
...em_wise_sales_register/item_wise_sales_register.py 51.36% <0.00%> (-11.82%) ⬇️
erpnext/stock/doctype/price_list/price_list.py 62.74% <0.00%> (-11.77%) ⬇️
...t/accounts/report/sales_register/sales_register.py 71.51% <0.00%> (-9.10%) ⬇️
...pnext/accounts/report/gross_profit/gross_profit.py 82.49% <0.00%> (-6.23%) ⬇️
...t/payroll/doctype/payroll_period/payroll_period.py 64.81% <0.00%> (-5.56%) ⬇️
... and 28 more

@ChillarAnand ChillarAnand marked this pull request as ready for review January 6, 2022 12:21
@ruchamahabal ruchamahabal self-assigned this Jan 12, 2022
@ankush ankush changed the title refactor: Removed hospitality domain from ERPNext refactor!: Removed hospitality domain from ERPNext Jan 20, 2022
@ankush ankush merged commit 2718ddd into frappe:develop Jan 20, 2022
@ruchamahabal ruchamahabal removed their assignment Jan 20, 2022
@ankush
Copy link
Member

ankush commented Jan 20, 2022

@ChillarAnand please port warning to v13.

'Hotel Manager',
'Hotel Reservation User'
],
'custom_fields': {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These custom fields should also be deleted in the patch

Copy link
Member

@ankush ankush Jan 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ankush

Added this point to the checklist as well. https://frappe.io/handbook/splitting-modules @ruchamahabal

@ChillarAnand
Copy link
Contributor Author

@ChillarAnand please port warning to v13.

Raised PR at #29384.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants