Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: GL Entries for loan repayment via Salary #29169

Merged

Conversation

deepeshgarg007
Copy link
Member

Closes: #28733, #26777, #26754

@codecov
Copy link

codecov bot commented Jan 6, 2022

Codecov Report

Merging #29169 (f316aaf) into develop (88df5ce) will increase coverage by 0.07%.
The diff coverage is 72.22%.

@@             Coverage Diff             @@
##           develop   #29169      +/-   ##
===========================================
+ Coverage    55.67%   55.74%   +0.07%     
===========================================
  Files         1128     1107      -21     
  Lines        67335    67369      +34     
===========================================
+ Hits         37488    37557      +69     
+ Misses       29847    29812      -35     
Impacted Files Coverage Δ
...anagement/doctype/loan_repayment/loan_repayment.py 89.18% <65.51%> (+1.79%) ⬆️
erpnext/payroll/doctype/salary_slip/salary_slip.py 83.92% <100.00%> (+0.19%) ⬆️
erpnext/utilities/product.py 14.70% <0.00%> (-35.30%) ⬇️
...wise_balance_history/batch_wise_balance_history.py 68.96% <0.00%> (-24.14%) ⬇️
erpnext/shopping_cart/product_info.py 30.30% <0.00%> (-21.22%) ⬇️
...t/product_bundle_balance/product_bundle_balance.py 81.81% <0.00%> (-13.64%) ⬇️
...work_order_stock_report/work_order_stock_report.py 94.11% <0.00%> (-5.89%) ⬇️
...eport/item_variant_details/item_variant_details.py 84.33% <0.00%> (-3.62%) ⬇️
.../report/bom_operations_time/bom_operations_time.py 93.33% <0.00%> (-3.34%) ⬇️
...xt/stock/report/stock_analytics/stock_analytics.py 91.08% <0.00%> (-2.98%) ⬇️
... and 80 more

@deepeshgarg007
Copy link
Member Author

@Mergifyio backport version-13-hotfix

@mergify
Copy link
Contributor

mergify bot commented Jan 7, 2022

backport version-13-hotfix

✅ Backports have been created

deepeshgarg007 added a commit that referenced this pull request Jan 7, 2022
…-29169

fix: GL Entries for loan repayment via Salary (backport #29169)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

loan repayment doesn't show in accounting ledger
1 participant