Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: seperate custom field creation for KSA #29175

Merged
merged 4 commits into from
Jan 15, 2022

Conversation

rtdany10
Copy link
Contributor

@rtdany10 rtdany10 commented Jan 6, 2022

If a company is created where country is Kingdom of Saudi Arabia, the system lazily copies the custom field creation from UAE setup. This PR aims to add only KSA specific fields upon setup.
Closes #29110

@rtdany10
Copy link
Contributor Author

rtdany10 commented Jan 6, 2022

We will need to run custom field creation patch once more for existing users. (https://github.com/frappe/erpnext/blob/develop/erpnext/patches/v13_0/create_ksa_vat_custom_fields.py)

Will shifting the order in patches.txt suffice?
@deepeshgarg007

@codecov
Copy link

codecov bot commented Jan 6, 2022

Codecov Report

Merging #29175 (2e5f22a) into develop (24fc487) will increase coverage by 0.06%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop   #29175      +/-   ##
===========================================
+ Coverage    55.71%   55.78%   +0.06%     
===========================================
  Files         1107     1107              
  Lines        67359    67371      +12     
===========================================
+ Hits         37532    37582      +50     
+ Misses       29827    29789      -38     
Impacted Files Coverage Δ
erpnext/regional/saudi_arabia/setup.py 0.00% <0.00%> (ø)
...ctype/woocommerce_settings/woocommerce_settings.py 80.00% <0.00%> (-4.00%) ⬇️
...ctype/accounting_dimension/accounting_dimension.py 64.06% <0.00%> (-1.57%) ⬇️
...e/period_closing_voucher/period_closing_voucher.py 88.23% <0.00%> (-1.48%) ⬇️
erpnext/portal/utils.py 28.98% <0.00%> (-1.45%) ⬇️
...ice_creation_tool/opening_invoice_creation_tool.py 60.95% <0.00%> (-0.69%) ⬇️
...rpnext/stock/report/stock_balance/stock_balance.py 79.16% <0.00%> (-0.60%) ⬇️
...next/accounts/doctype/subscription/subscription.py 81.84% <0.00%> (-0.56%) ⬇️
.../report/accounts_receivable/accounts_receivable.py 68.37% <0.00%> (-0.43%) ⬇️
erpnext/stock/doctype/serial_no/serial_no.py 79.62% <0.00%> (-0.27%) ⬇️
... and 18 more

@rtdany10 rtdany10 marked this pull request as ready for review January 7, 2022 07:31
@deepeshgarg007 deepeshgarg007 merged commit 3438e1f into frappe:develop Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Emirate Field Wrongly Created for Country = KSA
3 participants