fix: get project from PO into payment entry #29182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #29182 +/- ##
===========================================
+ Coverage 57.93% 58.01% +0.07%
===========================================
Files 1110 1110
Lines 68087 68090 +3
===========================================
+ Hits 39449 39504 +55
+ Misses 28638 28586 -52
|
| @@ -1522,6 +1523,8 @@ def get_payment_entry(dt, dn, party_amount=None, bank_account=None, bank_amount= | |||
| pe.paid_amount = paid_amount | |||
| pe.received_amount = received_amount | |||
| pe.letter_head = doc.get("letter_head") | |||
| if dt == 'Purchase Order': | |||
There was a problem hiding this comment.
This will also be applicable for other transactions like "Sales Order", "Purchase Receipt", "Delivery Note", "Sales Invoice" and "Purchase Invoice". Can we make this more generic to handle for all doctypes?
There was a problem hiding this comment.
We can avoid 'Purchase Receipt' and 'Delivery Note', as there are no process available to create Payment Entry from them.
- sales order, sales invoice, purchase order and purchase order - if project not found in transaction, get from items
|
@Mergifyio backport version-13-hotfix |
✅ Backports have been created
|
deepeshgarg007
added a commit
that referenced
this pull request
Jan 17, 2022
…-29182 fix: get project from PO into payment entry (backport #29182)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for Issue 16662
Now, creating payments for Purchase orders will pull the project from the line items.
no-docs