Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(asset): check if fixed asset account is set against company #29189

Merged
merged 5 commits into from
Jan 12, 2022

Conversation

nextchamp-saqib
Copy link
Member

@nextchamp-saqib nextchamp-saqib commented Jan 7, 2022

If you create an asset against a company and there are no accounts set in the asset category for that company, an error "Account not found" is thrown while making ledger entries on submission of asset.

@codecov
Copy link

codecov bot commented Jan 12, 2022

Codecov Report

Merging #29189 (66ee028) into develop (f811956) will increase coverage by 0.05%.
The diff coverage is 75.00%.

@@             Coverage Diff             @@
##           develop   #29189      +/-   ##
===========================================
+ Coverage    57.93%   57.99%   +0.05%     
===========================================
  Files         1110     1110              
  Lines        67991    67994       +3     
===========================================
+ Hits         39392    39432      +40     
+ Misses       28599    28562      -37     
Impacted Files Coverage Δ
erpnext/assets/doctype/asset/asset.py 75.28% <75.00%> (-0.06%) ⬇️
erpnext/crm/doctype/prospect/prospect.py 55.22% <0.00%> (-1.50%) ⬇️
.../hr/doctype/upload_attendance/upload_attendance.py 45.52% <0.00%> (-1.50%) ⬇️
erpnext/portal/utils.py 28.98% <0.00%> (-1.45%) ⬇️
.../report/stock_projected_qty/stock_projected_qty.py 88.15% <0.00%> (-1.32%) ⬇️
...xt/accounts/doctype/sales_invoice/sales_invoice.py 78.13% <0.00%> (-0.09%) ⬇️
erpnext/stock/reorder_item.py 75.21% <0.00%> (ø)
...ext/payroll/doctype/payroll_entry/payroll_entry.py 73.04% <0.00%> (+0.21%) ⬆️
erpnext/stock/doctype/serial_no/serial_no.py 79.94% <0.00%> (+0.26%) ⬆️
.../report/accounts_receivable/accounts_receivable.py 72.64% <0.00%> (+0.42%) ⬆️
... and 12 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant