Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deferred report division by zero exception #29193

Merged
merged 1 commit into from
Jan 11, 2022

Conversation

ruthra-kumar
Copy link
Member

Fixing issue where 'Deferred Revenue and Expense Report' throws exception if deferred item has no period (0 months).

Screenshot 2022-01-07 at 6 05 18 PM

@codecov
Copy link

codecov bot commented Jan 7, 2022

Codecov Report

Merging #29193 (fe4d7f8) into develop (44407e6) will increase coverage by 10.15%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##           develop   #29193       +/-   ##
============================================
+ Coverage    45.62%   55.78%   +10.15%     
============================================
  Files         1128     1107       -21     
  Lines        67295    67371       +76     
============================================
+ Hits         30705    37581     +6876     
+ Misses       36590    29790     -6800     
Impacted Files Coverage Δ
...evenue_and_expense/deferred_revenue_and_expense.py 61.30% <0.00%> (+61.30%) ⬆️
...t/product_bundle_balance/product_bundle_balance.py 81.81% <0.00%> (-13.64%) ⬇️
...ctype/woocommerce_settings/woocommerce_settings.py 80.00% <0.00%> (-4.00%) ⬇️
...e/asset_value_adjustment/asset_value_adjustment.py 86.04% <0.00%> (-3.49%) ⬇️
erpnext/accounts/doctype/party_link/party_link.py 83.33% <0.00%> (-2.39%) ⬇️
erpnext/stock/report/stock_ledger/stock_ledger.py 75.60% <0.00%> (-1.63%) ⬇️
...e/employee_benefit_claim/employee_benefit_claim.py 88.28% <0.00%> (-1.57%) ⬇️
.../hr/doctype/upload_attendance/upload_attendance.py 44.69% <0.00%> (-1.52%) ⬇️
...enefit_application/employee_benefit_application.py 32.70% <0.00%> (-0.63%) ⬇️
erpnext/accounts/deferred_revenue.py 75.87% <0.00%> (-0.44%) ⬇️
... and 280 more

@deepeshgarg007
Copy link
Member

@Mergifyio backport version-13-hotfix

@mergify
Copy link
Contributor

mergify bot commented Jan 11, 2022

backport version-13-hotfix

✅ Backports have been created

deepeshgarg007 added a commit that referenced this pull request Jan 13, 2022
…-29193

fix: deferred report division by zero exception (backport #29193)
@ruthra-kumar ruthra-kumar deleted the bug_deferred_report branch April 19, 2022 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants