Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use get_all instead of get_list while fetching SLA doctypes #29216

Merged
merged 3 commits into from Jan 11, 2022

Conversation

ruchamahabal
Copy link
Member

get_sla_doctypes is called on the app_ready event to show the SLA dashboard on whichever doctypes it is configured for. Due to this, users who have nothing to do with SLA get insufficient permission pop-up

image

Use get_all instead of instead of get_list to ignore permissions

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Jan 10, 2022
@ruchamahabal ruchamahabal removed the needs-tests This PR needs automated unit-tests. label Jan 10, 2022
@codecov
Copy link

codecov bot commented Jan 11, 2022

Codecov Report

Merging #29216 (c10e5d2) into develop (75c8b25) will increase coverage by 0.19%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop   #29216      +/-   ##
===========================================
+ Coverage    57.73%   57.93%   +0.19%     
===========================================
  Files         1110     1110              
  Lines        67992    67992              
===========================================
+ Hits         39258    39389     +131     
+ Misses       28734    28603     -131     
Impacted Files Coverage Δ
...service_level_agreement/service_level_agreement.py 82.98% <0.00%> (ø)
erpnext/utilities/product.py 14.70% <0.00%> (-35.30%) ⬇️
...wise_balance_history/batch_wise_balance_history.py 68.96% <0.00%> (-22.42%) ⬇️
erpnext/shopping_cart/product_info.py 30.30% <0.00%> (-21.22%) ⬇️
erpnext/stock/report/stock_ledger/stock_ledger.py 74.79% <0.00%> (-2.44%) ⬇️
erpnext/stock/report/stock_ageing/stock_ageing.py 91.32% <0.00%> (-2.32%) ⬇️
...e/shopping_cart_settings/shopping_cart_settings.py 66.03% <0.00%> (-1.89%) ⬇️
erpnext/shopping_cart/product_query.py 61.19% <0.00%> (-1.50%) ⬇️
erpnext/crm/doctype/prospect/prospect.py 55.22% <0.00%> (-1.50%) ⬇️
erpnext/accounts/deferred_revenue.py 75.87% <0.00%> (-0.88%) ⬇️
... and 23 more

@ruchamahabal ruchamahabal merged commit 2b33e63 into frappe:develop Jan 11, 2022
@ruchamahabal ruchamahabal deleted the fix-sla-perm branch January 11, 2022 09:10
@ruchamahabal
Copy link
Member Author

@Mergifyio backport version-13-hotfix

mergify bot pushed a commit that referenced this pull request Jan 11, 2022
…29216)

Co-authored-by: Ankush Menat <ankush@frappe.io>
(cherry picked from commit 2b33e63)

# Conflicts:
#	erpnext/support/doctype/service_level_agreement/service_level_agreement.py
@mergify
Copy link
Contributor

mergify bot commented Jan 11, 2022

backport version-13-hotfix

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants