Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pos): cannot ignore pricing rule for one particular invoice #29222

Merged
merged 3 commits into from
Jan 11, 2022

Conversation

nextchamp-saqib
Copy link
Member

  1. Create a POS Invoice using Form View
  2. Click on Ignore Pricing Rule
  3. Add an Item that has some Pricing Rule
  4. Save the document

You should see pricing rule has been applied and Ignore Pricing Rule is unchecked which shouldn't be the case.

Expected Behaviour:
Ignore Pricing Rule check shouldn't be overwritten from POS Profile. It should be only fetched initially from POS Profile

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Jan 10, 2022
@nextchamp-saqib nextchamp-saqib removed the needs-tests This PR needs automated unit-tests. label Jan 11, 2022
@codecov
Copy link

codecov bot commented Jan 11, 2022

Codecov Report

Merging #29222 (f1976c9) into develop (962dd5e) will increase coverage by 0.06%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #29222      +/-   ##
===========================================
+ Coverage    57.74%   57.81%   +0.06%     
===========================================
  Files         1110     1110              
  Lines        67991    67990       -1     
===========================================
+ Hits         39262    39309      +47     
+ Misses       28729    28681      -48     
Impacted Files Coverage Δ
...rpnext/accounts/doctype/pos_invoice/pos_invoice.py 71.80% <ø> (-0.08%) ⬇️
...wise_balance_history/batch_wise_balance_history.py 68.96% <0.00%> (-22.42%) ⬇️
erpnext/portal/utils.py 28.98% <0.00%> (-1.45%) ⬇️
erpnext/support/doctype/issue/issue.py 64.56% <0.00%> (-0.98%) ⬇️
.../report/accounts_receivable/accounts_receivable.py 71.36% <0.00%> (-0.43%) ⬇️
erpnext/stock/get_item_details.py 79.93% <0.00%> (-0.16%) ⬇️
erpnext/stock/report/stock_ageing/stock_ageing.py 93.06% <0.00%> (ø)
erpnext/stock/stock_ledger.py 85.76% <0.00%> (+0.36%) ⬆️
erpnext/portal/product_configurator/utils.py 34.00% <0.00%> (+0.40%) ⬆️
erpnext/selling/doctype/quotation/quotation.py 49.72% <0.00%> (+0.54%) ⬆️
... and 14 more

@nextchamp-saqib nextchamp-saqib merged commit 75c8b25 into frappe:develop Jan 11, 2022
@nextchamp-saqib
Copy link
Member Author

@Mergifyio backport version-13-hotfix

@mergify
Copy link
Contributor

mergify bot commented Jan 11, 2022

backport version-13-hotfix

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant