Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: description not fetch in sales order analytics report #29230

Merged
merged 2 commits into from
Jan 12, 2022

Conversation

nextchamp-saqib
Copy link
Member

In v12, the "Ordered Items to be Delivered" Report had a description column from the Sales Order Item.
This report was deleted in v13, as the "Sales Order Analytics" report fulfilled the purpose.
Users expect this description field to be present in the Sales Order Analytics report too.

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Jan 11, 2022
@codecov
Copy link

codecov bot commented Jan 11, 2022

Codecov Report

Merging #29230 (235e199) into develop (75c8b25) will increase coverage by 0.14%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop   #29230      +/-   ##
===========================================
+ Coverage    57.73%   57.88%   +0.14%     
===========================================
  Files         1110     1110              
  Lines        67992    67989       -3     
===========================================
+ Hits         39258    39353      +95     
+ Misses       28734    28636      -98     
Impacted Files Coverage Δ
erpnext/manufacturing/doctype/bom/bom.py 86.76% <ø> (-0.09%) ⬇️
...eport/sales_order_analysis/sales_order_analysis.py 0.00% <0.00%> (ø)
erpnext/utilities/product.py 14.70% <0.00%> (-35.30%) ⬇️
erpnext/shopping_cart/product_info.py 30.30% <0.00%> (-21.22%) ⬇️
...ctype/woocommerce_settings/woocommerce_settings.py 80.76% <0.00%> (-3.85%) ⬇️
...e/shopping_cart_settings/shopping_cart_settings.py 66.03% <0.00%> (-1.89%) ⬇️
...ctype/accounting_dimension/accounting_dimension.py 64.34% <0.00%> (-1.56%) ⬇️
erpnext/shopping_cart/product_query.py 61.19% <0.00%> (-1.50%) ⬇️
...e/period_closing_voucher/period_closing_voucher.py 88.23% <0.00%> (-1.48%) ⬇️
erpnext/stock/report/stock_ledger/stock_ledger.py 76.42% <0.00%> (-0.82%) ⬇️
... and 21 more

@nextchamp-saqib nextchamp-saqib added backport version-13-hotfix and removed needs-tests This PR needs automated unit-tests. labels Jan 12, 2022
@nextchamp-saqib nextchamp-saqib merged commit aef432e into frappe:develop Jan 12, 2022
mergify bot pushed a commit that referenced this pull request Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant