-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Don't validate FG in repack entry #29271
Merged
marination
merged 3 commits into
frappe:develop
from
marination:allow-multiple-fg-in-repack
Jan 13, 2022
Merged
fix: Don't validate FG in repack entry #29271
marination
merged 3 commits into
frappe:develop
from
marination:allow-multiple-fg-in-repack
Jan 13, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marination
force-pushed
the
allow-multiple-fg-in-repack
branch
from
January 13, 2022 07:59
46ee3d8
to
62e120f
Compare
marination
changed the title
fix: Allow multiple FG in repack entry
fix: Don't validate FG in repack entry
Jan 13, 2022
marination
force-pushed
the
allow-multiple-fg-in-repack
branch
from
January 13, 2022 08:14
62e120f
to
eac7b5d
Compare
- Also run fg validation and fg marking after checking purpose, avoid unnecessary calls
Codecov Report
@@ Coverage Diff @@
## develop #29271 +/- ##
===========================================
- Coverage 57.96% 57.74% -0.22%
===========================================
Files 1110 1110
Lines 68005 68005
===========================================
- Hits 39420 39271 -149
- Misses 28585 28734 +149
|
@Mergifyio backport version-13-hotfix |
✅ Backports have been created
|
marination
added a commit
that referenced
this pull request
Jan 13, 2022
…-29271 fix: Don't validate FG in repack entry (backport #29271)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#28555 missed the case of multiple FGs being possible in repack entries.
is_finished_item
auto checkedFix:
is_finished_item
checked, throw an errorTo test:
is_finished_item
checked is checked on the right rows