fix!: drop old broken demo files #29339
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dropping support for
make-demo
command; this hasn't worked properly for a long time now. If you ask me the main reason is schema/code for demo gets out of sync with other changes and that makes it unusable after few such breakages. Whoever wants to fix this make a separate app and ensure that it runs in CI else it will face the same fate again.Technically a breaking change; but is it breaking if it wasn't working? :thonk: