Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Cleanup empty rows on bank statement import #29366

Conversation

deepeshgarg007
Copy link
Member

@deepeshgarg007 deepeshgarg007 commented Jan 20, 2022

Bank Statement Import fails if there are empty rows in the template as follows and gives the below error

Traceback (most recent call last):
  File "apps/frappe/frappe/utils/background_jobs.py", line 104, in execute_job
    method(**kwargs)
  File "apps/erpnext/erpnext/accounts/doctype/bank_statement_import/bank_statement_import.py", line 111, in start_import
    add_bank_account(data, bank_account)
  File "apps/erpnext/erpnext/accounts/doctype/bank_statement_import/bank_statement_import.py", line 147, in add_bank_account
    row[bank_account_loc] = bank_account
IndexError: list assignment index out of range

image

Added a function to clean up empty rows before importing

@deepeshgarg007
Copy link
Member Author

@Mergifyio backport develop version-13-pre-release

@mergify
Copy link
Contributor

mergify bot commented Jan 20, 2022

backport develop version-13-pre-release

🟠 Waiting for conditions to match

  • merged [:pushpin: backport requirement]

@mergify
Copy link
Contributor

mergify bot commented Jan 20, 2022

backport develop version-13-pre-release

✅ Backports have been created

deepeshgarg007 added a commit that referenced this pull request Jan 20, 2022
fix: Cleanup empty rows on bank statement import (backport #29366)
deepeshgarg007 added a commit that referenced this pull request Jan 20, 2022
…se/pr-29366

fix: Cleanup empty rows on bank statement import (backport #29366)
fproldan added a commit to fproldan/erpnext that referenced this pull request Jan 28, 2022
ValentinaPruvost pushed a commit to fproldan/erpnext that referenced this pull request Jan 28, 2022
* trans: action in bank transaction tool

* trans: columns names in table

* trans: table row

* trans: table row

* trans: table row

* trans: table row

* fix: apply frappe#29098

* fix: apply frappe#29366

* fix: apply frappe#28996

* trans: fix
fproldan added a commit to fproldan/erpnext that referenced this pull request Jan 28, 2022
ValentinaPruvost pushed a commit to fproldan/erpnext that referenced this pull request Jan 31, 2022
* trans: columns names in table

* trans: table row

* trans: table row

* trans: table row

* trans: table row

* fix: apply frappe#29098

* fix: apply frappe#29366

* fix: apply frappe#28996

* trans: fix

* trans: action in bank transaction tool

* trans: fix
fproldan added a commit to fproldan/erpnext that referenced this pull request Mar 14, 2022
* trans: action in bank transaction tool

* trans: columns names in table

* trans: table row

* trans: table row

* trans: table row

* trans: table row

* fix: apply frappe#29098

* fix: apply frappe#29366

* fix: apply frappe#28996

* trans: fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant