Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cost center validation of asset #29373

Merged
merged 1 commit into from
Jan 21, 2022

Conversation

nextchamp-saqib
Copy link
Member

There was no validation on Cost Center while submitting Asset. You could select cost center of other Company and still submit the Asset

Added a validation for cost center

CleanShot 2022-01-20 at 11 55 02

@codecov
Copy link

codecov bot commented Jan 20, 2022

Codecov Report

Merging #29373 (4390adc) into develop (5ae44f3) will decrease coverage by 0.17%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop   #29373      +/-   ##
===========================================
- Coverage    58.06%   57.88%   -0.18%     
===========================================
  Files         1110     1110              
  Lines        68067    68073       +6     
===========================================
- Hits         39523    39404     -119     
- Misses       28544    28669     +125     
Impacted Files Coverage Δ
erpnext/assets/doctype/asset/asset.py 75.57% <100.00%> (+0.28%) ⬆️
...work_order_stock_report/work_order_stock_report.py 50.00% <0.00%> (-50.00%) ⬇️
...unts/report/purchase_register/purchase_register.py 32.19% <0.00%> (-41.10%) ⬇️
...ext/accounts/report/balance_sheet/balance_sheet.py 36.36% <0.00%> (-21.82%) ⬇️
...e_purchase_register/item_wise_purchase_register.py 58.00% <0.00%> (-17.00%) ⬇️
...payroll/doctype/income_tax_slab/income_tax_slab.py 83.33% <0.00%> (-16.67%) ⬇️
...t/payroll/doctype/payroll_period/payroll_period.py 64.81% <0.00%> (-5.56%) ⬇️
.../manufacturing/report/bom_explorer/bom_explorer.py 94.44% <0.00%> (-5.56%) ⬇️
...it_and_loss_statement/profit_and_loss_statement.py 71.42% <0.00%> (-3.90%) ⬇️
erpnext/assets/doctype/asset/depreciation.py 85.23% <0.00%> (-2.69%) ⬇️
... and 31 more

@nextchamp-saqib nextchamp-saqib merged commit 0666996 into frappe:develop Jan 21, 2022
nextchamp-saqib added a commit that referenced this pull request Jan 31, 2022
…-29373

fix: cost center validation of asset (backport #29373)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants