-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: (enhance) BOM Operations Report #29375
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added filters in the Report for BOM ID, Item Code and Workstation - Converted Raw SQL to frappe.qb and added method to get filtered data - Changed fieldtype of 'Time in mins' from Int to Float - Get BOM wise grouped data to keep order and accurate grouping in report
marination
added
backport version-13-hotfix
and removed
needs-tests
This PR needs automated unit-tests.
labels
Jan 20, 2022
Report does not do any extra computation, just formats data that's it. The basic test in |
Codecov Report
@@ Coverage Diff @@
## develop #29375 +/- ##
========================================
Coverage 57.88% 57.89%
========================================
Files 1091 1091
Lines 67850 67866 +16
========================================
+ Hits 39278 39288 +10
- Misses 28572 28578 +6
|
@Mergifyio backport version-13-hotfix |
✅ Backports have been created
|
marination
added a commit
that referenced
this pull request
Jan 20, 2022
…-29375 fix: (enhance) BOM Operations Report (backport #29375)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Fix:
To Test: