fix: can't cancel reconciliation that created new sr no #29393
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #25390
Steps to reproduce:
sr is undefined
.Root cause: stock reco was setting
"0"
ascurrent_serial_no
instead it should have been""
(empty string) orNone
.Fix: set current_serial_no to empty string when none are found
patch: update stock reco item row's serial no to
NULL
where qty is 0.Minor unrelated perf:
N+1
query for unlinking inactive serial nos instead ofN+2
. (will become just2
after frappe/frappe#15560 goes through)