fix: opening invoice creation tool can fetch multiple accounting dimension #29407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- create new dimension 'department' - assign and validate department in opening invoices
ruthra-kumar
requested review from
deepeshgarg007 and
nextchamp-saqib
as code owners
There was a problem hiding this comment.
- https://github.com/frappe/erpnext/wiki/Pull-Request-Checklist#linting follow this to setup pre-commit to avoid linting errors
- Other test cases seem to be failing because of the newly added test case for the opening invoice tool. Moving
create_dimensionsto setup and also also addingdisable_dimensionsin teardown will resolve this
deepeshgarg007
approved these changes
Jan 24, 2022
|
@Mergifyio backport version-13-hotfix |
✅ Backports have been created
|
deepeshgarg007
added a commit
that referenced
this pull request
Jan 24, 2022
…-29407 fix: opening invoice creation tool can fetch multiple accounting dimension (backport #29407)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Opening Invoice Creation tool has provision for accepting multiple accounting dimensions if they are already created in the system. But, the invoices created doesn't have the new accounting dimensions. It has been fixed with this change.
Screenshot
Creation Tool
Invoice