Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Validation for invalid serial nos at POS invoice level #29447

Merged

Conversation

nemesis189
Copy link
Contributor

Issue:
After auto fetching the serial nos in the POS screen if the serial is modified incorrectly no error will be thrown and the invoice gets submitted. It is thrown only during consolidation.

Fix:
Added validation for checking if the selected serial nos are valid or not.

Steps:
  1. Create a serialized item and create a Serial No for that item.
  2. In POS Screen add the serialized item, after setting the quantity auto fetch the serial nos
  3. Edit one of the serial nos
  4. After checkout it will throw a validation now:

    Note: Before the fix it would simply go ahead and submit the invoice and show the bill

@nemesis189 nemesis189 added this to the v13.20 milestone Jan 25, 2022
@codecov
Copy link

codecov bot commented Jan 31, 2022

Codecov Report

Merging #29447 (60b9e67) into develop (6b37770) will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop   #29447      +/-   ##
===========================================
+ Coverage    58.18%   58.28%   +0.09%     
===========================================
  Files         1096     1096              
  Lines        68765    68778      +13     
===========================================
+ Hits         40012    40086      +74     
+ Misses       28753    28692      -61     
Impacted Files Coverage Δ
...rpnext/accounts/doctype/pos_invoice/pos_invoice.py 72.75% <100.00%> (+0.94%) ⬆️
...work_order_stock_report/work_order_stock_report.py 50.00% <0.00%> (-50.00%) ⬇️
...tch_item_expiry_status/batch_item_expiry_status.py 69.23% <0.00%> (-25.00%) ⬇️
...wise_balance_history/batch_wise_balance_history.py 68.96% <0.00%> (-24.14%) ⬇️
...ctype/woocommerce_settings/woocommerce_settings.py 80.76% <0.00%> (-3.85%) ⬇️
...eport/item_variant_details/item_variant_details.py 84.33% <0.00%> (-3.62%) ⬇️
...xt/stock/report/stock_analytics/stock_analytics.py 91.08% <0.00%> (-1.99%) ⬇️
...eport/production_analytics/production_analytics.py 69.51% <0.00%> (-1.22%) ⬇️
erpnext/support/doctype/issue/issue.py 64.56% <0.00%> (-0.98%) ⬇️
erpnext/selling/doctype/quotation/quotation.py 49.18% <0.00%> (-0.55%) ⬇️
... and 19 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants