fix(sales order): incorrect no. of items fetched while creating dn #29454
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
If a Sales Order has more than 50 items (has multiple pages in item table), and there are some undelivered items. Some undelivered items have a different delivery date.
If some of the "undelivered items" belong to the next page of the items table for eg. an "undelivered item" has an index of 55 (like 51+)
Then while creating Delivery Note using Create button, those "next page" items are not fetched.
Why?
The
frm.fields_dict['items'].grid.grid_rows
contains only first 50 rows hence filtering only works on first 50 item rowserpnext/erpnext/selling/doctype/sales_order/sales_order.js
Lines 503 to 509 in c6a17d1