fix: Further sort sales_order_analysis to get consistent response #29471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surajshetty3416
requested review from
deepeshgarg007 and
nextchamp-saqib
as code owners
Since the data was sorted by `transaction_date`, report sorting order used to be inconsistent everytime if there were lots of records with same transaction date. This used to create problems while exporting report as "Excel" with filters.
surajshetty3416
force-pushed
the
fix-sorting
branch
from
54bff2a
to
29c7947
Compare
|
@Mergifyio backport version-13-hotfix |
🟠 Waiting for conditions to match
|
surajshetty3416
added
frappe-support
and removed
needs-tests
✅ Backports have been created
|
This was referenced Jul 4, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
transaction_date, the report sorting order used to be inconsistent every time if there were lots of records with the same transaction date. This is used to create problems while exporting reports as "Excel" with filters.For more details
https://frappe.io/app/issue/ISS-21-22-06182
more info: