Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ux): ensure correct-ish transfer against in BOM #29487

Merged
merged 2 commits into from
Jan 28, 2022

Conversation

ankush
Copy link
Member

@ankush ankush commented Jan 28, 2022

In BOM there are three options for transfer material against:

  • empty (to allow setting and using defaults while saving a new doc)
  • job card
  • work order

This PR adds some constraint/sane defaults:

  1. When there are no operations force Work Order.
  2. Don't allow empty transfer against.

Similarly for work order:

  1. If no operations are present then set "Work Order" as default material transfer against option while submitting.
  2. Don't allow empty transfer against.

Patch existing BOMs but not Work Order. (patching finished WO is not useful and ongoing WO anyways shouldn't be patched)

@ankush ankush changed the title fix: ensure correct-ish transfer against in BOM fix(ux): ensure correct-ish transfer against in BOM Jan 28, 2022
@ankush ankush force-pushed the wo_transfer_against_defaults branch from 4e02202 to b74feb1 Compare January 28, 2022 07:25
@ankush ankush added the needs-patch A patch to fix existing data is required label Jan 28, 2022
@ankush ankush removed the needs-patch A patch to fix existing data is required label Jan 28, 2022
@codecov
Copy link

codecov bot commented Jan 28, 2022

Codecov Report

Merging #29487 (125b571) into develop (b05287d) will increase coverage by 0.03%.
The diff coverage is 92.85%.

@@             Coverage Diff             @@
##           develop   #29487      +/-   ##
===========================================
+ Coverage    58.48%   58.52%   +0.03%     
===========================================
  Files         1091     1091              
  Lines        67885    67899      +14     
===========================================
+ Hits         39704    39737      +33     
+ Misses       28181    28162      -19     
Impacted Files Coverage Δ
...ext/manufacturing/doctype/work_order/work_order.py 74.77% <87.50%> (+0.15%) ⬆️
erpnext/manufacturing/doctype/bom/bom.py 86.98% <100.00%> (+0.12%) ⬆️
.../report/delayed_item_report/delayed_item_report.py 60.78% <0.00%> (-35.30%) ⬇️
...t/accounts/report/sales_register/sales_register.py 71.51% <0.00%> (-9.10%) ⬇️
...t/payroll/doctype/payroll_period/payroll_period.py 64.81% <0.00%> (-5.56%) ⬇️
...pnext/accounts/report/gross_profit/gross_profit.py 82.49% <0.00%> (-3.51%) ⬇️
...t/product_bundle_balance/product_bundle_balance.py 79.54% <0.00%> (-2.28%) ⬇️
...eorder_level/itemwise_recommended_reorder_level.py 92.45% <0.00%> (-1.89%) ⬇️
...em_wise_sales_register/item_wise_sales_register.py 61.36% <0.00%> (-1.82%) ⬇️
erpnext/portal/utils.py 28.98% <0.00%> (-1.45%) ⬇️
... and 27 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant