Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Interview ratings on job applicant dashboard #29506

Merged
merged 5 commits into from
Jan 29, 2022

Conversation

ruchamahabal
Copy link
Member

@ruchamahabal ruchamahabal commented Jan 29, 2022

Closes #29457
Closes #29459

Ratings on the job applicant dashboard not displayed correctly due to the ratings field changes in framework

image

image

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Jan 29, 2022
@ruchamahabal ruchamahabal removed the needs-tests This PR needs automated unit-tests. label Jan 29, 2022
@codecov
Copy link

codecov bot commented Jan 29, 2022

Codecov Report

Merging #29506 (0d5993d) into develop (eba0621) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop   #29506      +/-   ##
===========================================
+ Coverage    58.51%   58.58%   +0.06%     
===========================================
  Files         1091     1091              
  Lines        67999    68006       +7     
===========================================
+ Hits         39793    39838      +45     
+ Misses       28206    28168      -38     
Impacted Files Coverage Δ
...r/doctype/interview_feedback/interview_feedback.py 94.11% <ø> (-0.43%) ⬇️
erpnext/hr/doctype/interview/interview.py 65.44% <100.00%> (+1.87%) ⬆️
erpnext/hr/doctype/job_applicant/job_applicant.py 63.33% <100.00%> (+11.54%) ⬆️
...work_order_stock_report/work_order_stock_report.py 50.00% <0.00%> (-50.00%) ⬇️
erpnext/education/doctype/student/student.py 73.68% <0.00%> (-3.16%) ⬇️
...saction/incorrect_balance_qty_after_transaction.py 97.67% <0.00%> (-2.33%) ⬇️
...ion/doctype/course_enrollment/course_enrollment.py 44.00% <0.00%> (-2.00%) ⬇️
...eport/production_analytics/production_analytics.py 69.51% <0.00%> (-1.22%) ⬇️
erpnext/stock/reorder_item.py 76.92% <0.00%> (-0.86%) ⬇️
erpnext/assets/doctype/asset/asset.py 78.88% <0.00%> (-0.82%) ⬇️
... and 23 more

@ruchamahabal
Copy link
Member Author

@Mergifyio backport version-13-hotfix version-14-beta-pre-release

@mergify
Copy link
Contributor

mergify bot commented Jan 29, 2022

backport version-13-hotfix version-14-beta-pre-release

🟠 Waiting for conditions to match

  • merged [:pushpin: backport requirement]

@ruchamahabal ruchamahabal changed the title fix: interview ratings on job applicant dashboard fix: Interview ratings on job applicant dashboard Jan 29, 2022
@ruchamahabal ruchamahabal merged commit cc4b404 into frappe:develop Jan 29, 2022
@ruchamahabal ruchamahabal deleted the fix-interview-ratings branch January 29, 2022 16:21
@mergify
Copy link
Contributor

mergify bot commented Jan 29, 2022

backport version-13-hotfix version-14-beta-pre-release

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant