Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Total taxes and charges in payment entry for multi-currency payments #29977

Merged
merged 3 commits into from Feb 28, 2022
Merged

fix: Total taxes and charges in payment entry for multi-currency payments #29977

merged 3 commits into from Feb 28, 2022

Conversation

deepeshgarg007
Copy link
Member

@deepeshgarg007 deepeshgarg007 commented Feb 24, 2022 •
edited

Total Taxes and Charges for Party currency was not getting calculated properly

Before:
Screenshot 2022-02-28 at 7 04 29 PM

After:
Screenshot 2022-02-28 at 7 04 51 PM

Steps to test:

  1. Make a payment entry of type pay against a multicurrency supplier (not having paid to account currency same as company currency and paid from account having same as company)
  2. Add some taxes and charges
  3. Check if total taxes and charges show up correctly in both currencies (you can do the math)

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Feb 24, 2022
@deepeshgarg007
Copy link
Member Author

@Mergifyio backport version-13-hotfix

@deepeshgarg007 deepeshgarg007 merged commit 1191232 into frappe:develop Feb 28, 2022
@mergify mergify bot mentioned this pull request Feb 28, 2022
Merged
@mergify
Copy link
Contributor

mergify bot commented Feb 28, 2022

backport version-13-hotfix

✅ Backports have been created

deepeshgarg007 added a commit that referenced this pull request Feb 28, 2022
@deepeshgarg007
Merge pull request #30024 from frappe/mergify/bp/version-13-hotfix/pr…
fb05230 
…-29977

fix: Total taxes and charges in payment entry for multi-currency payments (backport #29977)
@deepeshgarg007 deepeshgarg007 mentioned this pull request Mar 8, 2022
Merged
@deepeshgarg007 deepeshgarg007 mentioned this pull request Mar 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nextchamp-saqib nextchamp-saqib Awaiting requested review from nextchamp-saqib

Assignees
No one assigned
Labels
needs-tests This PR needs automated unit-tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@deepeshgarg007