Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ignore disabled tax categories #30542

Merged

Conversation

deepeshgarg007
Copy link
Member

@deepeshgarg007 deepeshgarg007 commented Apr 1, 2022

Query should not consider disabled tax categories

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Apr 1, 2022
@codecov
Copy link

codecov bot commented Apr 1, 2022

Codecov Report

Merging #30542 (9a6a181) into develop (b981fae) will increase coverage by 8.70%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #30542      +/-   ##
===========================================
+ Coverage    52.28%   60.98%   +8.70%     
===========================================
  Files         1082     1083       +1     
  Lines        69067    69124      +57     
===========================================
+ Hits         36114    42158    +6044     
+ Misses       32953    26966    -5987     
Impacted Files Coverage Δ
erpnext/regional/india/utils.py 64.86% <ø> (+1.62%) ⬆️
...rial_no_valuation/incorrect_serial_no_valuation.py 85.96% <0.00%> (-10.53%) ⬇️
...rpnext/accounts/doctype/shareholder/shareholder.py 80.00% <0.00%> (-10.00%) ⬇️
...vs_serial_no_count/stock_qty_vs_serial_no_count.py 92.85% <0.00%> (-3.58%) ⬇️
erpnext/stock/doctype/warehouse/warehouse.py 82.78% <0.00%> (-1.64%) ⬇️
...e_sales_analytics/supplier_wise_sales_analytics.py 88.52% <0.00%> (-1.64%) ⬇️
erpnext/portal/utils.py 28.98% <0.00%> (-1.45%) ⬇️
erpnext/support/doctype/issue/issue.py 64.25% <0.00%> (-0.97%) ⬇️
...ctype/accounting_dimension/accounting_dimension.py 65.11% <0.00%> (-0.78%) ⬇️
...doctype/e_commerce_settings/e_commerce_settings.py 66.31% <0.00%> (-0.70%) ⬇️
... and 184 more

@deepeshgarg007
Copy link
Member Author

@Mergifyio backport version-13-hotfix

@deepeshgarg007 deepeshgarg007 merged commit 2e00678 into frappe:develop Apr 9, 2022
@mergify
Copy link
Contributor

mergify bot commented Apr 9, 2022

backport version-13-hotfix

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant