-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Multiple fixes in GST reporting #30978
Merged
deepeshgarg007
merged 10 commits into
frappe:version-13-hotfix
from
deepeshgarg007:gstr_export_sez_tax_rates
May 15, 2022
Merged
fix: Multiple fixes in GST reporting #30978
deepeshgarg007
merged 10 commits into
frappe:version-13-hotfix
from
deepeshgarg007:gstr_export_sez_tax_rates
May 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepeshgarg007
changed the title
fix: Multiple fixes in GSTR-1 report
fix: Multiple fixes in GST reporting
May 12, 2022
## [13.27.1](frappe/erpnext@v13.27.0...v13.27.1) (2022-04-26) ### Bug Fixes * Add accounting dimensions for round off GL Entry ([dedb90e](frappe@dedb90e)) * batch_no filtering not working when batch no is also a number in scientific notation ([frappe#30770](frappe#30770)) ([frappe#30771](frappe#30771)) ([c339305](frappe@c339305)) * Check if accounting dimension exists ([1834671](frappe@1834671)) * dependent gle reposting (backport [frappe#30726](frappe#30726)) ([frappe#30772](frappe#30772)) ([a6d0938](frappe@a6d0938)) * Do not validate while creating accounting dimension ([153b41a](frappe@153b41a)) * e_commerce_settings.js ([3a5f5d5](frappe@3a5f5d5)) * e_commerce_settings.py ([86c5f4d](frappe@86c5f4d)) * First preference to parent cost center rather than round off cost center ([a2d95fc](frappe@a2d95fc)) * Handle Multiselect field mapping separately ([dc2f694](frappe@dc2f694)) * **india:** 401 & 403 client error while generating IRN ([198bdcf](frappe@198bdcf)) * **india:** cess value not considered while validating e-invoice totals ([frappe#30800](frappe#30800)) ([f70fca1](frappe@f70fca1)) * **india:** transporter name is null while generating e-way bill ([frappe#30736](frappe#30736)) ([6291b28](frappe@6291b28)) * linter ([6dddbb9](frappe@6dddbb9)) * Loan doctypes in bank reconciliation ([e69c715](frappe@e69c715)) * Mistyped variable name in patch ([e76220e](frappe@e76220e)) * monthly attendance sheet ([frappe#30748](frappe#30748)) ([0b4e3f1](frappe@0b4e3f1)) * Must not be able to start Job Card if it is related to Work Order that is not started yet ([frappe#29072](frappe#29072)) ([frappe#30755](frappe#30755)) ([b656ffa](frappe@b656ffa)) * Query filter fields from Website Item instead of Item master ([bed9e09](frappe@bed9e09)) * select doctype as payment_document ([44f0b69](frappe@44f0b69)) * **Selling,E-Commerce:** Shopping cart quotation without website item. ([frappe#29085](frappe#29085)) ([ea0fe5e](frappe@ea0fe5e)) * SO analysis rpt will fetch SO's without Delivery note as well ([f9d89c7](frappe@f9d89c7)) * translation ([frappe#30781](frappe#30781)) ([frappe#30783](frappe#30783)) ([8335ca6](frappe@8335ca6)) * Update token to allow updates on protected branch ([baab379](frappe@baab379)) * update translation ([frappe#30725](frappe#30725)) ([frappe#30776](frappe#30776)) ([b585262](frappe@b585262)) * Use parent cost center for Sales and Purchase Invoice ([fe9f329](frappe@fe9f329)) * Use right precision for asset value after full schedule ([frappe#30745](frappe#30745)) ([269e192](frappe@269e192)) * Validate field filter wrt to Website Item & re-use validation in Item Group ([34437a8](frappe@34437a8))
# [13.28.0](frappe/erpnext@v13.27.1...v13.28.0) (2022-05-03) ### Bug Fixes * Consistent accounting dimensions across Sales and Purchase docs ([5df5058](frappe@5df5058)) * convert default_item_manufacturer to link field ([frappe#30835](frappe#30835)) ([frappe#30866](frappe#30866)) ([37fad7e](frappe@37fad7e)) * Cost center filter on payment reconciliation ([22e7f03](frappe@22e7f03)) * filters not working in Shift Assignment Calendar view ([frappe#30822](frappe#30822)) ([3cdbb65](frappe@3cdbb65)) * Ignore custom field validation while setup ([ee54bf7](frappe@ee54bf7)) * **india:** e-invoice generation for registered composition gst category type ([frappe#30814](frappe#30814)) ([frappe#30877](frappe#30877)) ([246869d](frappe@246869d)) * Multi currency opening invoices ([2e62d51](frappe@2e62d51)) * payment days calculation for employees joining/leaving mid-month ([frappe#30863](frappe#30863)) ([frappe#30883](frappe#30883)) ([a1b0813](frappe@a1b0813)) * Period Closing Voucher is considering GL entries with is_cancelled=1 ([frappe#30865](frappe#30865)) ([5a5b49b](frappe@5a5b49b)) * **pos:** number pad translations ([b01f855](frappe@b01f855)) * **pos:** search field doesn't reset on checkout ([edbf551](frappe@edbf551)) * Supply type for overseas invoices with payment of tax ([fdcc591](frappe@fdcc591)) * supply type for sez invoices with payment of tax ([cf08710](frappe@cf08710)) * Use `account_type == 'Stock'` to filter stock accounts ([93482f3](frappe@93482f3)) * **UX:** misleading stock entry lables ([frappe#30870](frappe#30870)) ([frappe#30871](frappe#30871)) ([57b03f0](frappe@57b03f0)) * **UX:** record reason for skipping attendance or marking absent for auto attendance ([frappe#30846](frappe#30846)) ([f7bf4a3](frappe@f7bf4a3)) * Vat Audit report fixes ([d5319a4](frappe@d5319a4)) ### Features * Copy task color from project template (backport [frappe#30857](frappe#30857)) ([frappe#30859](frappe#30859)) ([7ee18e8](frappe@7ee18e8)) * support product bundles in picklist (backport [frappe#30762](frappe#30762)) ([frappe#30826](frappe#30826)) ([645ee2d](frappe@645ee2d))
# [13.29.0](frappe/erpnext@v13.28.0...v13.29.0) (2022-05-10) ### Bug Fixes * Consider paryt and party type as well in group by consolidated view ([189fc89](frappe@189fc89)) * disable form save on naming series tool ([frappe#30909](frappe#30909)) ([frappe#30910](frappe#30910)) ([d60a6cb](frappe@d60a6cb)) * double future qty updates ([0db3013](frappe@0db3013)) * HSN-wise-summary of outward supplies Updated Report ([3637525](frappe@3637525)) * Ignore loan repayments made from salary slip ([b7e1d40](frappe@b7e1d40)) * **india:** invoice type for a debit note e-invoice ([frappe#30948](frappe#30948)) ([c46add3](frappe@c46add3)) * **india:** keyerror while generating e-way bill from an e-invoice ([frappe#30879](frappe#30879)) ([98d799e](frappe@98d799e)) * **india:** re-arrange e-way bill dialog fields ([frappe#30941](frappe#30941)) ([7ce5c93](frappe@7ce5c93)) * Item Alternative Test ([964de1f](frappe@964de1f)) * patch for renaming membership settings ([frappe#30929](frappe#30929)) ([9189653](frappe@9189653)) * **pos:** creating pos returns resets pricing rules & discounts ([frappe#30936](frappe#30936)) ([a0e39db](frappe@a0e39db)) * remove check for already allocated earned leaves ([frappe#30931](frappe#30931)) ([frappe#30932](frappe#30932)) ([80f7d66](frappe@80f7d66)) * Remove commit from stock entry test. The assertion is not important ([c449b35](frappe@c449b35)) * Set available-for-use date if missing ([frappe#30838](frappe#30838)) ([bf2eaec](frappe@bf2eaec)) * show group warehouse in Sales Order ([frappe#30891](frappe#30891)) ([frappe#30893](frappe#30893)) ([c458e14](frappe@c458e14)) * Show linked time sheets in sales invoice dashboard ([4f4af52](frappe@4f4af52)) * sort before picking next stock reco ([e27fb58](frappe@e27fb58)) * subtract change_amount from paid_amount field on POS Register ([frappe#30937](frappe#30937)) ([b7e873b](frappe@b7e873b)) * Unlink and delete batch created from stock reco on cancel ([fc35323](frappe@fc35323)) * Wrap SLE actual_qty in `flt` to avoid NoneType operation ([d53228b](frappe@d53228b)) ### Features * **HR:** Leave Type configuration to allow over allocation (backport [frappe#30940](frappe#30940)) ([frappe#30944](frappe#30944)) ([64440fc](frappe@64440fc)) * **india:** cancel e-way bill is enabled with e-invoicing APIs. ([frappe#30924](frappe#30924)) ([4ef2ffd](frappe@4ef2ffd)) * **india:** generate qrcode button for e-invoice ([frappe#30946](frappe#30946)) ([7bd5b2b](frappe@7bd5b2b)) * **india:** store e-way bill auto calculated distance in sales invoice ([frappe#30923](frappe#30923)) ([b96f156](frappe@b96f156))
deepeshgarg007
force-pushed
the
gstr_export_sez_tax_rates
branch
from
May 13, 2022 12:42
aca6456
to
cb8453d
Compare
@Mergifyio backport develop |
✅ Backports have been created
|
deepeshgarg007
added a commit
that referenced
this pull request
May 16, 2022
fix: Multiple fixes in GST reporting (backport #30978)
🎉 This PR is included in version 13.30.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. SEZ and Export Invoices without payment of tax in GSTR-1 report
Currently, SEZ invoices without payment of tax did not use to show up in the GSTR-1 report since no GST was applied in it, this PR fixes that, SEZ and Export invoices (without payment of tax) also showed tax rates as 0 as no GST was applied. This was incorrect, invoices even without payment of taxes should be reported based on their HSN tax rate
For this have introduced a new table GST Tax rate in GST HSN Code doctype which will be used to fetch GST rates for items in such invoices
2. UOM fix in HSN wise summary of outward supplies
If two items have different UOM but the same HSN code if sold in a single month then in HSN-Wise summary of outward supply on one UOM is shown and the qty is wrong
3. Sync tax rates in HSN Codes
Tax rates for some HSN codes have been bootstrapped. The sync rates button can be used to sync the system HSN codes
4. Other misc fixes: