refactor: Accounts Receivable/Payable Report will use Payment Ledger

[ruthra-kumar]

Accounts Receivable/Payable Report

Change in this PR

• Accounts Receivable/Payable report has been refactored to use Payment Ledger as data source
• unit test for AR/AP report refactored as well.

[codecov]

Codecov Report

Merging #31107 (4d9f815) into develop (3a3d136) will decrease coverage by 0.48%.
The diff coverage is 64.10%.

❗ Current head 4d9f815 differs from pull request most recent head ea276a7. Consider uploading reports for the commit ea276a7 to get more accurate results

@@             Coverage Diff             @@
##           develop   #31107      +/-   ##
===========================================
- Coverage    63.56%   63.07%   -0.49%     
===========================================
  Files          985      986       +1     
  Lines        67567    67386     -181     
===========================================
- Hits         42949    42506     -443     
- Misses       24618    24880     +262     

Impacted Files	Coverage Δ
.../report/accounts_receivable/accounts_receivable.py	70.97% <64.10%> (-1.15%)	⬇️
...tion_detail/employee_benefit_application_detail.py	0.00% <0.00%> (-100.00%)	⬇️
...unts/report/purchase_register/purchase_register.py	34.21% <0.00%> (-42.77%)	⬇️
...enefit_application/employee_benefit_application.py	34.96% <0.00%> (-29.53%)	⬇️
...mission/employee_tax_exemption_proof_submission.py	76.92% <0.00%> (-23.08%)	⬇️
...ext/accounts/report/balance_sheet/balance_sheet.py	36.36% <0.00%> (-21.82%)	⬇️
...e_purchase_register/item_wise_purchase_register.py	57.42% <0.00%> (-19.81%)	⬇️
..._declaration/employee_tax_exemption_declaration.py	75.00% <0.00%> (-18.94%)	⬇️
...t/payroll/doctype/payroll_period/payroll_period.py	64.81% <0.00%> (-18.52%)	⬇️
erpnext/regional/india/utils.py	64.50% <0.00%> (-10.92%)	⬇️
... and 65 more

[centaur78]

Hi @ruthra-kumar

I getting the below reports... where both the Accounts Receivable and Payable have entries dating back from 2020 which are not show here. This was showing when GL entry was used as source

and

Error

[ruthra-kumar]

@centaur78 Check if the old GL postings have been migrated to Payment Ledger. If not run patch 'erpnext.patches.v14_0.migrate_gl_to_payment_ledger' on your site. If you are still facing this issue, create an issue ticket

[centaur78]

Hi @ruthra-kumar

How do you run a specific patch like 'erpnext.patches.v14_0.migrate_gl_to_payment_ledger' ??

I did bench update --patch but it still shows the same result

[ankush]

Check patch log doctype, and see if there are any with migrate_gl_to_payment_ledger already. If so it has already ran on your site.

[centaur78]

Check patch log doctype, and see if there are any with migrate_gl_to_payment_ledger already. If so it has already ran on your site.

Hi @ankush
yes just checked... there is no erpnext.patches.v14_0.migrate_gl_to_payment_ledger in the logs ..

So how would I run this patch specifically ?

[ruthra-kumar]

@centaur78

use
bench --site <sitename> run-patch --force erpnext.patches.v14_0.migrate_gl_to_payment_ledger

You have to clear 'Payment Ledger Entry' table beforehand using DB console though. Otherwise, you will get duplicate entries.