refactor: Payment Reconciliation tool will use Payment Ledger #31136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #31136 +/- ##
===========================================
- Coverage 63.92% 63.87% -0.06%
===========================================
Files 984 984
Lines 67573 67723 +150
===========================================
+ Hits 43197 43258 +61
- Misses 24376 24465 +89
|
ruthra-kumar
force-pushed
the
refactor_payment_reconciliation_tool
branch
5 times, most recently
from
8e2cdac
to
cb792dd
Compare
ankush
force-pushed
the
refactor_payment_reconciliation_tool
branch
from
4c7087a
to
492f193
Compare
ruthra-kumar
force-pushed
the
refactor_payment_reconciliation_tool
branch
from
492f193
to
171c317
Compare
ruthra-kumar
requested review from
nextchamp-saqib and
deepeshgarg007
as code owners
ruthra-kumar
force-pushed
the
refactor_payment_reconciliation_tool
branch
2 times, most recently
from
8871025
to
e8f0544
Compare
ruthra-kumar
force-pushed
the
refactor_payment_reconciliation_tool
branch
2 times, most recently
from
fe0e0b2
to
cc13b42
Compare
ruthra-kumar
force-pushed
the
refactor_payment_reconciliation_tool
branch
2 times, most recently
from
0978be7
to
6e3ba51
Compare
deepeshgarg007
requested changes
Jun 16, 2022
ruthra-kumar
force-pushed
the
refactor_payment_reconciliation_tool
branch
2 times, most recently
from
e49aa77
to
927f468
Compare
PR uses payment ledger for outstanding invoice and unreconcilied cr/dr notes.
unit test cases for partial reconciliation, return invoice against invoice, invoice against journals and journal against journal have been added
outstanding invoice function has been refactored to use payment ledger
Payment entry has option to select outstanding invoices using a popup form. This change refactors the pop to use payment ledger to fetch +ve outstanding invoices.
Outstanding amount is updated from payment ledger, only for receivable/payable accounts. For remaining account types, update happens from GL Entry.
ruthra-kumar
force-pushed
the
refactor_payment_reconciliation_tool
branch
from
927f468
to
3a238b4
Compare
ankush
reviewed
Jul 7, 2022
Comment on lines
+37
to
+42
| ret = frappe.db.sql( | ||
| """select is_group, docstatus, company | ||
| from tabAccount where name=%s""", | ||
| self.account, | ||
| as_dict=1, | ||
| )[0] |
There was a problem hiding this comment.
- why raw sql?
retis bad variable name 😅,accountoraccount_dataadds more info.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Payment Reconciliation tool
Refactoring the reconciliation tool to use Payment ledger for pulling invoices and return invoices with outstanding balances.
Changes in this PR