-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(india): Generate E-way Bill with IRN Settings #31143
feat(india): Generate E-way Bill with IRN Settings #31143
Conversation
i have added settings for e-way bill under E Invoice Setting doctype. I have also changed Label for advanced_settings_section to GSP Setting
settings and logic is added so user can choose their desired flow for ewaybill generation when generating irn. allows eway bill generation for part A & B before ewaybill was only generated if transporter(part A) was added. msgprint for eway bill errors while generating irn is added. E-Way bill details added to GST E-Invoice print format.
fixes test that was failing due to added conditional argument that adds eway fields
…com/maharshivpatel/erpnext into feat-india-eway-generation-settings
Codecov Report
@@ Coverage Diff @@
## develop #31143 +/- ##
===========================================
- Coverage 63.59% 63.41% -0.19%
===========================================
Files 988 988
Lines 67576 67614 +38
===========================================
- Hits 42977 42875 -102
- Misses 24599 24739 +140
|
This reverts commit c1fd5cc.
I have reverted all of the unnecessary formatting and changed modified date.
@nextchamp-saqib hope you are doing well, are there any issues/improvements that I can solve to make this PR merge faster? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes
Co-authored-by: Saqib Ansari <nextchamp.saqib@gmail.com>
I have refactored code using guard clauses instead of if-else and separated method for parsing "info" in response.
This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing. |
Problem: If Transport details are available while generating IRN ewaybill will be generated without consent.
user also doesn't have an indicator if eway bill will be generated.
Cases:
Current vs Proposed Flow
I have added e-way bill settings and renamed the label of the advanced setting to GSP Setting as it was more appropriate
Note: I have considered "" value as "Always Ask" and "Always" for eway_auto_generate and eway_when_generate respectively
as there is some bug and because of that the default value of the select field is not honored.Generate IRN Preview Changes
If ewaybill will be generated.
If ewaybill will not be generated.
GST E-Invoice Print Format Changes
If IRN is not generated:
If Eway Bill Details are available:
no-docs