Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: two new groupby mode on gross profit: Monthly, Payment Term #31198

Merged
merged 1 commit into from
Jun 10, 2022
Merged

feat: two new groupby mode on gross profit: Monthly, Payment Term #31198

merged 1 commit into from
Jun 10, 2022

Conversation

HarryPaulo
Copy link
Contributor

@HarryPaulo HarryPaulo commented May 31, 2022

I created two new grouping ways:

Monthly: The grouping is based on the Month / Year, allowing an evolution view for the user with the results of each month of the chosen filter

Demo: https://prnt.sc/BqpVgZyPnbov

Payment Term: This mode presents the profitability based on the payment schedule from sales invoice and group by Payment Term, with 2 fixed types:

Sales Return: whenever there is a sales return, this text will be assigned, as returns do not have a "Payment Schedule"

No Terms: When a sales invoice is made and the payment terms are not informed.

Demo: https://prnt.sc/aOsAzWQ-WZPb

no-docs

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label May 31, 2022
@codecov
Copy link

codecov bot commented May 31, 2022

Codecov Report

Merging #31198 (c4af63a) into develop (a1b7a79) will increase coverage by 0.04%.
The diff coverage is 42.10%.

@@             Coverage Diff             @@
##           develop   #31198      +/-   ##
===========================================
+ Coverage    63.29%   63.34%   +0.04%     
===========================================
  Files          986      986              
  Lines        67367    67395      +28     
===========================================
+ Hits         42642    42688      +46     
+ Misses       24725    24707      -18     
Impacted Files Coverage Δ
...pnext/accounts/report/gross_profit/gross_profit.py 73.06% <42.10%> (-7.19%) ⬇️
.../report/delayed_item_report/delayed_item_report.py 60.78% <0.00%> (-35.30%) ⬇️
...rial_no_valuation/incorrect_serial_no_valuation.py 85.96% <0.00%> (-10.53%) ⬇️
...pnext/setup/doctype/sales_partner/sales_partner.py 65.21% <0.00%> (-4.35%) ⬇️
erpnext/hr/doctype/job_applicant/job_applicant.py 63.93% <0.00%> (-3.28%) ⬇️
...e_sales_analytics/supplier_wise_sales_analytics.py 86.88% <0.00%> (-3.28%) ⬇️
...next/accounts/doctype/bank_account/bank_account.py 77.27% <0.00%> (-2.28%) ⬇️
erpnext/stock/doctype/warehouse/warehouse.py 79.02% <0.00%> (-2.10%) ⬇️
...eorder_level/itemwise_recommended_reorder_level.py 90.74% <0.00%> (-1.86%) ⬇️
erpnext/crm/doctype/prospect/prospect.py 56.71% <0.00%> (-1.50%) ⬇️
... and 21 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accounts needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants