fix: unnecessary GLE reposts #31240
Merged
fix: unnecessary GLE reposts #31240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
accounts
needs-tests
Codecov Report
@@ Coverage Diff @@
## develop #31240 +/- ##
===========================================
- Coverage 63.50% 63.33% -0.18%
===========================================
Files 986 986
Lines 67457 67460 +3
===========================================
- Hits 42838 42725 -113
- Misses 24619 24735 +116
|
In Sales/Purchase invoices credit/debit are flipped and negated while making GLE, this is unflipped while posting them but if we compare the flipped ones it will always result in comparison failure and repost it.
If you have a huge list of docs to repost then maintaining transaction throughtout entire GL reposting is not only unnecessary but also creates performance issues. Periodically commiting the changes prevents lost progress and reduces memory usage.
ankush
requested review from
marination and
rohitwaghchaure
and removed request for
nextchamp-saqib and
deepeshgarg007
ankush
added a commit
to ankush/erpnext
that referenced
this pull request
Jun 15, 2022
ankush
added a commit
to ankush/erpnext
that referenced
this pull request
Jun 15, 2022
ankush
added a commit
that referenced
this pull request
Jun 15, 2022
) * fix: dont use cached doc for GLE reposts ported from #31240 * perf: GLE reposting with progress and chunking If stock voucher count goes >1000 then fetching all gles and reposting them all at once requires much more memory and can cause crash. - This PR ensures that GLE reposting is done in chunks of 100 vouchers. - This PR also starts keeping track of how many such chunks were processed so in future progress is resumed in event of timeout. * test: add "actual" test for chunked GLE reposting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Sales/Purchase invoices credit/debit are flipped and negated while making GLE,
this is unflipped while posting them but if we compare the flipped ones
it will always result in comparison failure and repost it.