fix(ux): Add tabs in Item

[rmehta]

[codecov]

Codecov Report

Merging #31284 (5c69378) into develop (c3f2201) will increase coverage by 0.10%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #31284      +/-   ##
===========================================
+ Coverage    63.40%   63.50%   +0.10%     
===========================================
  Files          986      986              
  Lines        67440    67457      +17     
===========================================
+ Hits         42759    42838      +79     
+ Misses       24681    24619      -62     

Impacted Files	Coverage Δ
...t/product_bundle_balance/product_bundle_balance.py	79.54% <0.00%> (-15.91%)	⬇️
...rpnext/accounts/doctype/shareholder/shareholder.py	80.00% <0.00%> (-10.00%)	⬇️
...saction/incorrect_balance_qty_after_transaction.py	88.37% <0.00%> (-9.31%)	⬇️
erpnext/hr/doctype/job_offer/job_offer.py	82.92% <0.00%> (-4.88%)	⬇️
erpnext/accounts/party.py	78.43% <0.00%> (-4.21%)	⬇️
...ext/stock/doctype/stock_entry/stock_entry_utils.py	93.33% <0.00%> (-2.32%)	⬇️
erpnext/stock/reorder_item.py	73.33% <0.00%> (-1.67%)	⬇️
erpnext/portal/utils.py	27.69% <0.00%> (-1.54%)	⬇️
...pnext/accounts/report/gross_profit/gross_profit.py	80.24% <0.00%> (-1.24%)	⬇️
erpnext/support/doctype/issue/issue.py	64.25% <0.00%> (-0.97%)	⬇️
... and 32 more

[chechani]

Thanks to include the Tab item doctype that deserves TabBreak field most ..

We found 3 issues in Item Doctype after updating

1. There is a link field for Doctype Billing Type, which is not there in the System.
2. There are 2 details tab
3. No data can be seen in any of the details Tab & Dashboard Tab refer screenshot

[rmehta]

@chechani did you add new tabs via customize form?

[chechani]

No, It's a fresh install for testing without any customisation. In Item doctype, the Hubsync field (why does it exist?) is already there through the customisation hence Details tab is visible twice probably. Details Tab is visible sometimes and sometimes not that is an issue if we create a new doctype too and we created an issue already about that frappe/frappe#16645 .

Our observation is that if you refresh the page Details page will be visible definitely and hence we have a workaround through a client script to refresh the page for a doctype that has a tabbreak field.

[ankush]

Faced this locally as well, seems like a problem with tabs, not just this PR. (no errors or anyhing, some tabs just dont load)

[rmehta]

https://github.com/frappe/frappe/pull/17108/files#diff-1dc5b7a41767010f76111c10a9c3680d518f6bc395aa0a35c8b530c4bb8db3dfL6 should fix it

[chechani]

@rmehta , it worked well! Thanks a lot and salute to you!

[yadavyk]

Use case : While creating template item, the "maintain stock" checkbox has to be unchecked so that item variants can be created. However upon checking "maintain stock" , the inventory tab hides. GIF for reference :

@rmehta , is this intentional ?

[rmehta]

@yadavyk will push a fix