Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update Period Closing Voucher per Company #31295

Merged
merged 1 commit into from
Jun 10, 2022
Merged

fix: update Period Closing Voucher per Company #31295

merged 1 commit into from
Jun 10, 2022

Conversation

zeta17
Copy link
Contributor

@zeta17 zeta17 commented Jun 9, 2022

add query for each company when checking existing Period Closing Voucher

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Jun 9, 2022
@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #31295 (68e8d86) into develop (5c69378) will increase coverage by 0.04%.
The diff coverage is 66.66%.

@@             Coverage Diff             @@
##           develop   #31295      +/-   ##
===========================================
+ Coverage    63.50%   63.54%   +0.04%     
===========================================
  Files          986      986              
  Lines        67457    67457              
===========================================
+ Hits         42838    42867      +29     
+ Misses       24619    24590      -29     
Impacted Files Coverage Δ
...e/period_closing_voucher/period_closing_voucher.py 88.23% <ø> (ø)
...t/accounts/report/sales_register/sales_register.py 81.87% <ø> (ø)
erpnext/e_commerce/redisearch_utils.py 36.42% <ø> (ø)
erpnext/loan_management/doctype/loan/loan.py 67.78% <44.44%> (ø)
...ext/stock/doctype/stock_entry/stock_entry_utils.py 93.33% <66.66%> (ø)
...ounts/doctype/purchase_invoice/purchase_invoice.py 83.48% <100.00%> (ø)
erpnext/controllers/sales_and_purchase_return.py 91.41% <100.00%> (-0.75%) ⬇️
erpnext/regional/india/e_invoice/utils.py 38.53% <100.00%> (ø)
erpnext/hr/doctype/job_applicant/job_applicant.py 63.93% <0.00%> (-3.28%) ⬇️
... and 21 more

@ankush ankush changed the title Update Period Closing Voucher per Company fix: update Period Closing Voucher per Company Jun 9, 2022
@deepeshgarg007 deepeshgarg007 merged commit 74b274f into frappe:develop Jun 10, 2022
@deepeshgarg007
Copy link
Member

@Mergifyio backport version-13-hotfix

@mergify
Copy link
Contributor

mergify bot commented Jun 10, 2022

backport version-13-hotfix

✅ Backports have been created

@ankush ankush removed the needs-tests This PR needs automated unit-tests. label Jun 10, 2022
deepeshgarg007 added a commit that referenced this pull request Jun 11, 2022
…-31295

fix: update Period Closing Voucher per Company (backport #31295)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants