Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: filter set in Bank Clearance Summary #31395

Merged
merged 1 commit into from
Jun 23, 2022
Merged

fix: filter set in Bank Clearance Summary #31395

merged 1 commit into from
Jun 23, 2022

Conversation

nihantra
Copy link
Contributor

Version
ERPNext: v14.0.0-develop
Frappe Framework: v14.x.x-develop

  • Please also update version 13

Before:

  • In Bank Clearance Summary, when entering values in the filter for amount column, it does not filter out the rows (Amount).
  • Because field type does not define.
before_bank_clearance_summary.mp4

After Develop:

  • Set field type of amount in bank_clearance_summary.py
{"label": _("Amount"), "fieldname": "amount", "fieldtype": "Currency", "width": 120},
  • Then after checking so the amount filter works properly.
after_bank_clearance_summary.mp4

Thank You!

@codecov
Copy link

codecov bot commented Jun 17, 2022

Codecov Report

Merging #31395 (0097a2b) into develop (10583eb) will increase coverage by 0.01%.
The diff coverage is 97.14%.

@@             Coverage Diff             @@
##           develop   #31395      +/-   ##
===========================================
+ Coverage    63.64%   63.66%   +0.01%     
===========================================
  Files          984      984              
  Lines        67562    67573      +11     
===========================================
+ Hits         43001    43019      +18     
+ Misses       24561    24554       -7     
Impacted Files Coverage Δ
...xt/accounts/doctype/journal_entry/journal_entry.py 68.95% <ø> (ø)
...t/bank_clearance_summary/bank_clearance_summary.py 0.00% <ø> (ø)
erpnext/accounts/utils.py 70.32% <ø> (ø)
.../report/procurement_tracker/procurement_tracker.py 90.19% <ø> (ø)
erpnext/controllers/accounts_controller.py 85.57% <ø> (-0.24%) ⬇️
.../hr/doctype/leave_application/leave_application.py 82.37% <ø> (ø)
erpnext/hr/utils.py 76.40% <ø> (ø)
...cturing/doctype/production_plan/production_plan.py 74.86% <ø> (ø)
...ext/manufacturing/doctype/work_order/work_order.py 78.31% <ø> (ø)
...ext/payroll/doctype/payroll_entry/payroll_entry.py 77.49% <ø> (ø)
... and 54 more

@deepeshgarg007
Copy link
Member

@Mergifyio backport version-13-hotfix

@mergify
Copy link
Contributor

mergify bot commented Jun 23, 2022

backport version-13-hotfix

✅ Backports have been created

deepeshgarg007 added a commit that referenced this pull request Jun 23, 2022
…-31395

fix: filter set in Bank Clearance Summary (backport #31395)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants