Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect outstanding for invoice #31442

Conversation

ruthra-kumar
Copy link
Member

Incorrect credit_in_account_currency is populated for GL entries split based on cost centre allocation. This causes incorrect outstanding amount to be calculated for Invoices.

Screenshot 2022-06-24 at 4 42 08 PM

@github-actions github-actions bot added accounts needs-tests This PR needs automated unit-tests. labels Jun 24, 2022
@ruthra-kumar ruthra-kumar force-pushed the incorrect_outstanding_on_multiple_cost_centers branch from 009b42f to 321fea3 Compare June 24, 2022 12:18
@codecov
Copy link

codecov bot commented Jun 24, 2022

Codecov Report

Merging #31442 (321fea3) into develop (ea28ed1) will increase coverage by 0.28%.
The diff coverage is 88.29%.

@@             Coverage Diff             @@
##           develop   #31442      +/-   ##
===========================================
+ Coverage    63.68%   63.97%   +0.28%     
===========================================
  Files          984      984              
  Lines        67573    67763     +190     
===========================================
+ Hits         43037    43348     +311     
+ Misses       24536    24415     -121     
Impacted Files Coverage Δ
...xt/accounts/doctype/payment_entry/payment_entry.py 69.38% <41.66%> (+0.28%) ⬆️
...ctype/payment_ledger_entry/payment_ledger_entry.py 76.36% <73.33%> (-13.64%) ⬇️
...e/payment_reconciliation/payment_reconciliation.py 92.51% <93.61%> (+7.71%) ⬆️
erpnext/accounts/utils.py 73.53% <97.77%> (+3.21%) ⬆️
erpnext/accounts/doctype/gl_entry/gl_entry.py 69.10% <100.00%> (-3.00%) ⬇️
...xt/accounts/doctype/journal_entry/journal_entry.py 69.08% <100.00%> (+0.13%) ⬆️
erpnext/accounts/general_ledger.py 95.00% <100.00%> (+0.40%) ⬆️
erpnext/hr/doctype/job_offer/job_offer.py 82.92% <0.00%> (-4.88%) ⬇️
...facturing/doctype/bom_update_log/bom_update_log.py 86.72% <0.00%> (-3.18%) ⬇️
... and 41 more

@deepeshgarg007 deepeshgarg007 merged commit 9c1eb77 into frappe:develop Jun 25, 2022
@ruthra-kumar ruthra-kumar deleted the incorrect_outstanding_on_multiple_cost_centers branch June 14, 2023 16:05
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accounts needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants