Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: Remove HR and Payroll modules from ERPNext #31467

Merged
merged 58 commits into from
Jul 20, 2022

Commits on Jun 10, 2022

  1. chore: move widely used doctypes from HR to Setup module

    - Employee: used in Telephony, Stock, Quality, Projects, Manufacturing, Loans, Buying, Assets, Accounts, Dependent Apps: Healthcare
    
    - Holiday List: CRM (Appointment Booking), Projects, Healthcare, Support (SLA), Education (Student's Holiday List)
    
    - Branch: Selling (SMS Center), used widely as an accounting dimension
    
    - Department: Assets, Projects, SMS Center, used widely as an accounting dimension
    
    - Designation: Lead, Healthcare Practitioner, used in Employee master which will now be in core
    
    - Employee Group: Telephony, Communication
    
    - Child Tables for above dts: Employee Group Table (Employee Group), Employee Education (Employee), Employee External Work History (Employee), Employee Internal Work History (Employee), Designation Skill (Designation), Holiday (Holiday List)
    ruchamahabal committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    f520f04 View commit details
    Browse the repository at this point in the history
  2. fix: remove HR specific fields from depatment and employee

    - these will be added to the masters as custom fields on HRMS app setup
    ruchamahabal committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    a117af2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0d34e58 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    512c82f View commit details
    Browse the repository at this point in the history
  5. fix: remove employee reminders, move to HRMS app

    - change `erpnext.hr.EmployeeController` to `erpnext.setup.EmployeeController`
    ruchamahabal committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    85b18e2 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    ab8df98 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2022

  1. fix: remove active employee validation from timesheets

    - moved to hrms hooks, will only be triggered if app is installed
    ruchamahabal committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    23b40ff View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2022

  1. Configuration menu
    Copy the full SHA
    8b2d045 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3fe2ef6 View commit details
    Browse the repository at this point in the history
  3. fix: removed expense claim, advance and salary slip updates from PE/J…

    …E events
    
    - moved them to HRMS app hooks
    ruchamahabal committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    0f83e7a View commit details
    Browse the repository at this point in the history
  4. chore: remove test for employee

    - Moved to the HRMS app
    ruchamahabal committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    39c30f5 View commit details
    Browse the repository at this point in the history
  5. fix: remove Salary Slip creation from Timesheet

    - moved to HRMS app
    ruchamahabal committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    4b3fb83 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2022

  1. chore: Remove HR/Payroll related setups and fixtures

    - Fixtures moved to HRMS app
    
    - 'HR' field in Terms and Conditions removed, added via HRMS setup
    ruchamahabal committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    fbc1330 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2022

  1. chore: Removed payroll dependencies from Loan Management, moved to hr…

    …ms app
    
    - Salary Slip Loan dt moved to hrms, removed from erpnext app
    
    - Repay from Salary field removed from Loan and Loan Repayment, installed on hrms app setup
    
    - fixed references to salary slip loan fields
    ruchamahabal committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    f6fbcc9 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2022

  1. chore: Extract Expense Claim, FnF, Gratuity, Employee Advance related…

    … code from accounting
    
    - Added hooks `advance_payment_doctypes`, `invoice_doctypes`, `period_closing_doctypes` for other apps to extend accounting functionality
    
    - Removed `set_query` code from `journal_entry.js` and `payment_entry.js`
    
    - removed `update_status_for_full_and_final_statement` trigger on JE submission/cancellation
    
    - refactored `payment_entry.py`: split functions for validating reference doctypes for easy overriding, removed hrms references from `get_reference_details` and `get_payment_entry`
    
    - removed dead code: functions `get_bill_no_and_update_amounts`, `get_total_amount_exchange_rate_base_on_currency`, `get_total_amount_exchange_rate_for_employee_advance`, `get_amounts_based_on_ref_doc`, `get_amounts_based_on_reference_doctype`
    ruchamahabal committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    1ff0e45 View commit details
    Browse the repository at this point in the history
  2. chore: Remove code for Expense Claim from Project, Task, Delivery Trip

    - Remove `total_expense_claim` field from Project and Task, will be installed with hrms setup
    
    - Remove Expense Claim calculation from `update_costing` in project
    
    - Remove `update_total_expense_claim` from task
    
    - Remove Expense Claim references from employee form tour
    
    - Remove 'Make Expense Claim' button from Delivery Trip, will only be available if hrms is installed
    
    - Update delivery trip tests
    ruchamahabal committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    edb528c View commit details
    Browse the repository at this point in the history
  3. chore: Remove HR related reports from other modules

    - Project Profitability report: Projects
    
    - Employee Hours Utilization Based on Timesheet: Projects
    
    - Unpaid Expense Claims: Accounts
    ruchamahabal committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    eac58ab View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2022

  1. chore: Remove HR related field references from Employee, Department f…

    …orm scripts
    
    - removed approver fields and payroll cost center from Employee master
    
    - removed query filter code for HR related fields from employee and department form scripts
    
    - removed `update_approver_role`
    ruchamahabal committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    39e0d22 View commit details
    Browse the repository at this point in the history
  2. fix: remove HR/Payroll references from form dashboards

    - Employee, Holiday List, Project, Task, Timesheet
    ruchamahabal committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    c619b58 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2022

  1. chore: Remove regional HR reports, custom field setups

    - Removed reports Provident Fund Deductions, Professional Tax Deductions, helper js file `salary_slip_deductions_report_filters.js`
    
    - Removed Gratuity rules setup for India and UAE
    
    - Removed custom field setup for India
    
    - Moved all setups to the HRMS app
    ruchamahabal committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    1d5c866 View commit details
    Browse the repository at this point in the history
  2. chore: Remove HR templates and references from other workspaces

    - Removed template `employees_to_mark_attendance.html`
    
    - Removed HR references from ERPNext Settings and Home workspaces
    ruchamahabal committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    ba8ea0f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2b255bd View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c8712b0 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    930e557 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2022

  1. Configuration menu
    Copy the full SHA
    6a65c8a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6f407d3 View commit details
    Browse the repository at this point in the history
  3. chore: Remove links for Employee Hours Utilization Based On Timesheet…

    … and Project Profitability from Projects workspace
    ruchamahabal committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    3c059de View commit details
    Browse the repository at this point in the history
  4. chore: Add Fleet Management masters in Setup module for Delivery Trip

    - Driver, Vehicle, Driving License Category (child table)
    
    - Removed Email Account setup for Job Applicant from setup wizard
    ruchamahabal committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    6bee20c View commit details
    Browse the repository at this point in the history
  5. fix: Remove Designation Skill child table

    - moved to HRMS app, since it isn't used anywhere in ERPNext
    ruchamahabal committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    26a8de6 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    a24cc98 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2022

  1. Configuration menu
    Copy the full SHA
    ef63c61 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f0e2bdf View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    211b46b View commit details
    Browse the repository at this point in the history
  4. fix: patches

    ruchamahabal committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    1497e26 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2022

  1. fix: Remove HR & Payroll Settings from Company master

    - moved setup to HRMS app
    ruchamahabal committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    9f7511d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3051f6e View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2022

  1. Configuration menu
    Copy the full SHA
    7442a88 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a1a6810 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ef72994 View commit details
    Browse the repository at this point in the history
  4. fix: Remove Expense Claim from Bank Reconciliation

    - add hooks `get_matching_queries` and `bank_reconciliation_doctypes` to extend the functionality in other apps
    ruchamahabal committed Jul 1, 2022
    Configuration menu
    Copy the full SHA
    466bf99 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2022

  1. Configuration menu
    Copy the full SHA
    2da427c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    694d35e View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2022

  1. Configuration menu
    Copy the full SHA
    ef02e58 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2248276 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    64075cb View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    108cce2 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2022

  1. Configuration menu
    Copy the full SHA
    f6fb00b View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2022

  1. Configuration menu
    Copy the full SHA
    cd9a01b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5a51951 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2022

  1. Configuration menu
    Copy the full SHA
    d8aa1c5 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2022

  1. Configuration menu
    Copy the full SHA
    db586af View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2022

  1. Configuration menu
    Copy the full SHA
    f765428 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2022

  1. Configuration menu
    Copy the full SHA
    2ae48fb View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2022

  1. Configuration menu
    Copy the full SHA
    eae3996 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8ce5261 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b30f66c View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2022

  1. Configuration menu
    Copy the full SHA
    f2532a6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f222284 View commit details
    Browse the repository at this point in the history