Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: timeout error while reposting #31519

Merged

Conversation

rohitwaghchaure
Copy link
Collaborator

Issue
While reposting system getting timeout error

Cause

During reposting, if there is any dependent entries found then system do the reposting of all the dependent entries. This process takes time specially when there are multiple dependent entries.

Solution

Instead of reposting dependent entries immediately, we have pushed dependent entries in Queue. The queued items will be complete one by one and we store the last stage after each item. In case if process terminated then system will start the reposting from last stage and not from the beginning

@codecov
Copy link

codecov bot commented Jul 5, 2022

Codecov Report

Merging #31519 (96f46b2) into develop (37f7801) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop   #31519      +/-   ##
===========================================
+ Coverage    64.33%   64.35%   +0.01%     
===========================================
  Files          965      965              
  Lines        65156    65153       -3     
===========================================
+ Hits         41918    41929      +11     
+ Misses       23238    23224      -14     
Impacted Files Coverage Δ
erpnext/stock/stock_ledger.py 91.19% <100.00%> (+0.61%) ⬆️
...em_wise_sales_register/item_wise_sales_register.py 50.45% <0.00%> (-10.91%) ⬇️
...t/accounts/report/sales_register/sales_register.py 73.68% <0.00%> (-8.19%) ⬇️
...eorder_level/itemwise_recommended_reorder_level.py 90.74% <0.00%> (-1.86%) ⬇️
erpnext/stock/doctype/item_price/item_price.py 92.98% <0.00%> (-1.76%) ⬇️
erpnext/portal/utils.py 27.69% <0.00%> (-1.54%) ⬇️
erpnext/crm/doctype/prospect/prospect.py 49.25% <0.00%> (-1.50%) ⬇️
erpnext/controllers/sales_and_purchase_return.py 91.41% <0.00%> (-0.75%) ⬇️
erpnext/stock/report/stock_ageing/stock_ageing.py 95.19% <0.00%> (-0.49%) ⬇️
...t/accounts/report/general_ledger/general_ledger.py 67.57% <0.00%> (-0.35%) ⬇️
... and 16 more

@rohitwaghchaure rohitwaghchaure merged commit 8eb676e into frappe:develop Jul 6, 2022
@rohitwaghchaure
Copy link
Collaborator Author

@Mergifyio backport version-13-hotfix

@mergify
Copy link
Contributor

mergify bot commented Jul 6, 2022

backport version-13-hotfix

✅ Backports have been created

rohitwaghchaure added a commit that referenced this pull request Jul 6, 2022
…-31519

fix: timeout error while reposting (backport #31519)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant