fix: Maintain backward compatibility with older bench versions #31542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Older versions of bench depend on `name` in setup.py Setting it to `frappe` causes some weird behavior like moving `apps/erpnext` to `apps/frappe`
ankush
approved these changes
Jul 6, 2022
gavindsouza
pushed a commit
to gavindsouza/erpnext
that referenced
this pull request
Jul 25, 2022
…e#31542) Older versions of bench depend on `name` in setup.py Setting it to `frappe` causes some weird behavior like moving `apps/erpnext` to `apps/frappe`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Older versions of bench depend on
namein setup.pySetting it to
frappecauses some weird behavior like movingapps/erpnexttoapps/frappeAnd thanks to our error reporting
failspasses without any error messageGetting erpnext $ git clone https://github.com/frappe/erpnext --depth 1 --origin upstream Cloning into 'erpnext'... INFO: A newer version of bench is available: 5.2.1 → 5.12.1