Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: intercompany SO created from Purchase Order throws exception #31777

Merged
merged 1 commit into from
Aug 8, 2022

Conversation

ruthra-kumar
Copy link
Member

@ruthra-kumar ruthra-kumar commented Aug 4, 2022

Issue

Inter company Sales Order created from a Purchase Order throws exception.

Fix

Received items fetched only for Sales Invoice/Orders.

closes #31590

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Aug 4, 2022
@codecov
Copy link

codecov bot commented Aug 4, 2022

Codecov Report

Merging #31777 (af0a353) into develop (1a2ffc7) will decrease coverage by 0.24%.
The diff coverage is 50.00%.

@@             Coverage Diff             @@
##           develop   #31777      +/-   ##
===========================================
- Coverage    63.53%   63.28%   -0.25%     
===========================================
  Files          813      813              
  Lines        57506    57520      +14     
===========================================
- Hits         36536    36402     -134     
- Misses       20970    21118     +148     
Impacted Files Coverage Δ
...xt/accounts/doctype/sales_invoice/sales_invoice.py 78.53% <50.00%> (-0.07%) ⬇️
...unts/report/purchase_register/purchase_register.py 34.21% <0.00%> (-38.82%) ⬇️
.../report/delayed_item_report/delayed_item_report.py 60.78% <0.00%> (-35.30%) ⬇️
...ext/accounts/report/balance_sheet/balance_sheet.py 36.36% <0.00%> (-21.82%) ⬇️
...e_purchase_register/item_wise_purchase_register.py 57.42% <0.00%> (-16.84%) ⬇️
...rial_no_valuation/incorrect_serial_no_valuation.py 85.96% <0.00%> (-10.53%) ⬇️
...rpnext/accounts/doctype/shareholder/shareholder.py 80.00% <0.00%> (-10.00%) ⬇️
...pnext/accounts/report/gross_profit/gross_profit.py 73.80% <0.00%> (-4.80%) ⬇️
...pnext/setup/doctype/sales_partner/sales_partner.py 65.21% <0.00%> (-4.35%) ⬇️
erpnext/utilities/activation.py 62.85% <0.00%> (-2.86%) ⬇️
... and 24 more

@deepeshgarg007
Copy link
Member

@Mergifyio backport version-14-hotfix version-13-hotfix

@mergify
Copy link
Contributor

mergify bot commented Aug 8, 2022

backport version-14-hotfix version-13-hotfix

✅ Backports have been created

deepeshgarg007 added a commit that referenced this pull request Aug 8, 2022
…-31777

fix: intercompany SO created from Purchase Order throws exception (backport #31777)
deepeshgarg007 added a commit that referenced this pull request Aug 8, 2022
…-31777

fix: intercompany SO created from Purchase Order throws exception (backport #31777)
@ruthra-kumar ruthra-kumar deleted the intercompany_po_bug branch June 14, 2023 16:05
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-tests This PR needs automated unit-tests.
Projects
None yet
2 participants