Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: two new filters for gross profit #31850

Merged

Conversation

HarryPaulo
Copy link
Contributor

@HarryPaulo HarryPaulo commented Aug 15, 2022

For report Gross Profit was added two new Filters Item Group and Sales Team
no-docs

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Aug 15, 2022
@codecov
Copy link

codecov bot commented Aug 15, 2022

Codecov Report

Merging #31850 (ad8d0ef) into develop (0047e18) will decrease coverage by 0.10%.
The diff coverage is 60.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #31850      +/-   ##
===========================================
- Coverage    63.41%   63.30%   -0.11%     
===========================================
  Files          813      813              
  Lines        57530    57615      +85     
===========================================
- Hits         36483    36474       -9     
- Misses       21047    21141      +94     
Impacted Files Coverage Δ
...pnext/accounts/report/gross_profit/gross_profit.py 78.26% <60.00%> (-0.34%) ⬇️
...eport/item_variant_details/item_variant_details.py 31.32% <0.00%> (-55.43%) ⬇️
...rial_no_valuation/incorrect_serial_no_valuation.py 59.64% <0.00%> (-36.85%) ⬇️
.../report/delayed_item_report/delayed_item_report.py 60.78% <0.00%> (-35.30%) ⬇️
...e_sales_analytics/supplier_wise_sales_analytics.py 57.37% <0.00%> (-32.79%) ⬇️
...tch_item_expiry_status/batch_item_expiry_status.py 67.92% <0.00%> (-24.53%) ⬇️
...wise_balance_history/batch_wise_balance_history.py 67.79% <0.00%> (-22.04%) ⬇️
...saction/incorrect_balance_qty_after_transaction.py 88.37% <0.00%> (-9.31%) ⬇️
.../buying/doctype/buying_settings/buying_settings.py 90.90% <0.00%> (-9.10%) ⬇️
.../fifo_queue_vs_qty_after_transaction_comparison.py 86.20% <0.00%> (-8.63%) ⬇️
... and 50 more

@stale
Copy link

stale bot commented Aug 31, 2022

This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label Aug 31, 2022
@HarryPaulo
Copy link
Contributor Author

Wating for reviewers

@stale stale bot removed the inactive label Aug 31, 2022
@deepeshgarg007
Copy link
Member

@Mergifyio backport version-14-hotfix

@deepeshgarg007 deepeshgarg007 merged commit acb88e5 into frappe:develop Sep 4, 2022
@mergify
Copy link
Contributor

mergify bot commented Sep 4, 2022

backport version-14-hotfix

✅ Backports have been created

deepeshgarg007 added a commit that referenced this pull request Sep 4, 2022
…-31850

feat: two new filters for gross profit (backport #31850)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants