Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: not able to issue expired batches #31863

Merged

Conversation

rohitwaghchaure
Copy link
Collaborator

While issuing expired batches system throwing an error
Screenshot 2022-08-17 at 12 20 27 PM

@codecov
Copy link

codecov bot commented Aug 17, 2022

Codecov Report

Merging #31863 (795c943) into develop (1a2ffc7) will decrease coverage by 0.36%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop   #31863      +/-   ##
===========================================
- Coverage    63.53%   63.16%   -0.37%     
===========================================
  Files          813      813              
  Lines        57506    57537      +31     
===========================================
- Hits         36536    36343     -193     
- Misses       20970    21194     +224     
Impacted Files Coverage Δ
erpnext/controllers/stock_controller.py 92.16% <100.00%> (+0.37%) ⬆️
...eport/item_variant_details/item_variant_details.py 31.32% <0.00%> (-55.43%) ⬇️
...unts/report/purchase_register/purchase_register.py 34.21% <0.00%> (-38.82%) ⬇️
.../report/delayed_item_report/delayed_item_report.py 60.78% <0.00%> (-35.30%) ⬇️
...tch_item_expiry_status/batch_item_expiry_status.py 67.92% <0.00%> (-24.53%) ⬇️
...wise_balance_history/batch_wise_balance_history.py 67.79% <0.00%> (-22.04%) ⬇️
...e_purchase_register/item_wise_purchase_register.py 57.42% <0.00%> (-16.84%) ⬇️
...em_wise_sales_register/item_wise_sales_register.py 50.45% <0.00%> (-12.28%) ⬇️
...rial_no_valuation/incorrect_serial_no_valuation.py 85.96% <0.00%> (-10.53%) ⬇️
...rpnext/accounts/doctype/shareholder/shareholder.py 80.00% <0.00%> (-10.00%) ⬇️
... and 42 more

@rohitwaghchaure rohitwaghchaure merged commit dd08045 into frappe:develop Aug 17, 2022
@rohitwaghchaure
Copy link
Collaborator Author

@Mergifyio backport version-13-hotfix version-14-hotfix

@mergify
Copy link
Contributor

mergify bot commented Aug 17, 2022

backport version-13-hotfix version-14-hotfix

❌ No backport have been created

rohitwaghchaure added a commit that referenced this pull request Aug 17, 2022
…-31863

fix: not able to issue expired batches (backport #31863)
rohitwaghchaure added a commit that referenced this pull request Aug 17, 2022
…-31863

fix: not able to issue expired batches (backport #31863)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant